From a025e7fd4f475c149b1906b5a790d25e2c781530 Mon Sep 17 00:00:00 2001 From: Jen Young Date: Mon, 29 Oct 2018 09:38:07 -0700 Subject: [PATCH 1/6] Set client_id variable --- library/HelloSign/Test/TemplateTest.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/library/HelloSign/Test/TemplateTest.php b/library/HelloSign/Test/TemplateTest.php index 68940bb..528bdd2 100644 --- a/library/HelloSign/Test/TemplateTest.php +++ b/library/HelloSign/Test/TemplateTest.php @@ -187,7 +187,8 @@ public function testUpdateTemplateFiles() { $templates = $this->client->getTemplates(); $template_id = $templates[0]->getId(); - + $client_id = $_ENV['CLIENT_ID']; + $request = new \HelloSign\Template(); $request->enableTestMode(); $request->setClientId($client_id); From 2dfa6ccfa5ad44f1dfb4853810fa644f9d7e47fc Mon Sep 17 00:00:00 2001 From: Jen Young Date: Wed, 31 Oct 2018 13:29:01 -0700 Subject: [PATCH 2/6] Update constructor for BulkSendJob --- library/HelloSign/BulkSendJob.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/library/HelloSign/BulkSendJob.php b/library/HelloSign/BulkSendJob.php index 93b0c21..a08a7ef 100644 --- a/library/HelloSign/BulkSendJob.php +++ b/library/HelloSign/BulkSendJob.php @@ -184,7 +184,10 @@ public function getSignatureRequests() */ public function __construct($response = null, $options = array()) { - $this->signature_requests = $response->signature_requests; + if (isset($response->signature_requests)) + { + $this->signature_requests = $response->signature_requests; + } $this->list_info = $response->list_info; parent::__construct($response, $options); From 1b7a571e8aed7f6dd7fd7d68ca36a05a4ecbe3b3 Mon Sep 17 00:00:00 2001 From: Jen Young Date: Wed, 31 Oct 2018 13:34:54 -0700 Subject: [PATCH 3/6] Update BulkSendJob constructor method to account for null response arguments --- library/HelloSign/BulkSendJob.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/library/HelloSign/BulkSendJob.php b/library/HelloSign/BulkSendJob.php index a08a7ef..3c154a7 100644 --- a/library/HelloSign/BulkSendJob.php +++ b/library/HelloSign/BulkSendJob.php @@ -184,11 +184,11 @@ public function getSignatureRequests() */ public function __construct($response = null, $options = array()) { - if (isset($response->signature_requests)) + if (isset($response)) { $this->signature_requests = $response->signature_requests; + $this->list_info = $response->list_info; } - $this->list_info = $response->list_info; parent::__construct($response, $options); } From 286fac6b611c0591e444c13bce08213905c5b072 Mon Sep 17 00:00:00 2001 From: Jen Young Date: Thu, 1 Nov 2018 09:56:45 -0700 Subject: [PATCH 4/6] Adjust constructor method for response --- library/HelloSign/BulkSendJob.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/library/HelloSign/BulkSendJob.php b/library/HelloSign/BulkSendJob.php index 3c154a7..4506d5f 100644 --- a/library/HelloSign/BulkSendJob.php +++ b/library/HelloSign/BulkSendJob.php @@ -184,9 +184,13 @@ public function getSignatureRequests() */ public function __construct($response = null, $options = array()) { - if (isset($response)) + if (isset($response->signature_requests)) { $this->signature_requests = $response->signature_requests; + } + + if (isset($response->list_info)) + { $this->list_info = $response->list_info; } From 992414d348ba152827ed11284942c18f0c8bbd49 Mon Sep 17 00:00:00 2001 From: Jen Young Date: Thu, 1 Nov 2018 10:11:32 -0700 Subject: [PATCH 5/6] Version bump to 3.5.6 --- library/HelloSign/Client.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library/HelloSign/Client.php b/library/HelloSign/Client.php index 239e389..840647c 100644 --- a/library/HelloSign/Client.php +++ b/library/HelloSign/Client.php @@ -41,7 +41,7 @@ class Client { - const VERSION = '3.5.5'; + const VERSION = '3.5.6'; const API_URL = "https://api.hellosign.com/v3/"; From 4887cbcd67acbe3f29d1c18b0f9defc637fca335 Mon Sep 17 00:00:00 2001 From: Jen Young Date: Thu, 1 Nov 2018 10:12:31 -0700 Subject: [PATCH 6/6] Add Travis CI badge into README --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 8bc99b8..23feb4a 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,5 @@ ## HelloSign PHP SDK +[![Build Status](https://travis-ci.org/hellosign/hellosign-php-sdk.svg?branch=v3)](https://travis-ci.org/hellosign/hellosign-php-sdk) This is the official PHP SDK for HelloSign's API. [View API Documentation and Examples.](https://app.hellosign.com/api/documentation)