New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring #17
Refactoring #17
Conversation
I think simplifying the CI / support requirements #21 could make the burden on this a bit easier. |
@tony thanks You so much for get package back to life. But main thing here - start support jinja templates same way as django after in-depth refactoring of jinja extension |
Maybe it will just easier to copy-paste this jinja tag in-to master? |
Do you want to keep your cache refactor, though? That takes up a big portion of the PR. |
I can not push You to do it, but include version of django-activeurl in-to cache key can be very useful for someone during upgrade, especially when behaviour of packages is changed due awesome |
It'd be good to have push access or to be added to the issue so I can fix the commit w/ you |
Invitation is send, all write access will be granted, except master branch which is becomes protected right now. |
Some missing things We need setup.py classifier regarding Python3.6 'open' is setup.py must be 'io.open' , All if statements must use new bool helper |
Updated
Can you give me some examples of this by commenting the code? |
This landscape and covverals goes crazy, I think we need to remove them and setup codecov service |
I prefer codecov too. Let's add it to refactor-tests #29 |
If statment comment is merge diff missunderstood Can You merge refactring tests to this branch and lets see how it goes green together |
I would prefer merging #29 into master first (it looks neater since I like to cite it at https://devel.tech/site/open-source), I'm almost finished with it. |
No description provided.