Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for python 3.6, django 1.10+ #21

Merged
merged 2 commits into from Jul 25, 2017

Conversation

tony
Copy link
Collaborator

@tony tony commented Jul 24, 2017

Help catch us up to latest django and python versions.

Let's see what travis says about this first.

@tony
Copy link
Collaborator Author

@tony tony commented Jul 24, 2017

https://travis-ci.org/hellysmile/django-activeurl/builds/257108895?utm_source=github_status&utm_medium=notification

The current state of what we're testing against is out of control.

We should bump up the minimum Django version and Python version.

Currently, we're testing Django 1.3 to 1.9 (and 1.9 is from github tarball since a package probably wasn't on pypi at the time)

Bump to django 1.8+?

https://github.com/django-extensions/django-extensions is for Django 1.8 or later. That seems like a fair thing to test again.

Django 1.8 LTS EOL is April 2018.

Just for CI / tests

Though, this should effect CI only. Since this plugin is simple, older versions will likely keep working.

@hellysmile Thoughts on deprecating old versions, at least from CI?

@coveralls
Copy link

@coveralls coveralls commented Jul 24, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling bac899f on develtech:update-tests into dc0c979 on hellysmile:master.

1 similar comment
@coveralls
Copy link

@coveralls coveralls commented Jul 24, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling bac899f on develtech:update-tests into dc0c979 on hellysmile:master.

@tony tony mentioned this pull request Jul 25, 2017
- DJANGO="https://github.com/django/django/tarball/stable/1.9.x#egg=django"
- DJANGO="django>=1.9,<1.10"
- DJANGO="django>=1.10,<1.11"
- DJANGO="django>=1.11,<1.12"
matrix:
exclude:
- python: "3.5"
Copy link
Owner

@hellysmile hellysmile Jul 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to exclude not supported django versions for 3.6

@tony
Copy link
Collaborator Author

@tony tony commented Jul 25, 2017

let's follow up with this and #22 AM tomorrow my time (CDT). if you have any other things (code smells/nitpicks/mistakes I made) let me know and I'll tend to them too.

@hellysmile hellysmile merged commit a41b025 into hellysmile:master Jul 25, 2017
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants