Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upsupport for ignoring get params #20 #22
Conversation
django_activeurl/utils.py
Outdated
| # check missing href parameter | ||
| if not url.attrib.get('href', None) is None: | ||
| # get href attribute | ||
| href = url.attrib['href'].strip() | ||
| # cut off hashtag (anchor) | ||
| href = re.sub(r'\#.+', '', href) | ||
| if ignore_params: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tony
Jul 25, 2017
•
Collaborator
This is actually less performant IMO, but I added it in 21ce8a3. While it feels good to work with the standard library.
- it turns out urlparse objects aren't mutable. The reason why is the object subclasses
tuple. _replaceis available, but still does a copy every time
So don't you think re.sub would be more performant? Since there's no additional urlsplit / tuple object created?
tony
added some commits
Jul 25, 2017
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Jul 25, 2017
•
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Jul 25, 2017
•
hellysmile
merged commit 41b25cc
into
hellysmile:master
Jul 25, 2017
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build failed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tony commentedJul 25, 2017
Also, decouple off yes/no functionality into
yesno_to_boolfunction.