New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use __about__ for package metadata on docs and setup #25

Merged
merged 3 commits into from Jul 27, 2017

Conversation

Projects
None yet
3 participants
@tony
Copy link
Collaborator

tony commented Jul 27, 2017

This way, only one location needs to be updated for package versions/naming on docs/conf.py and setup.py.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ad7381b on develtech:package-meta into a41b025 on hellysmile:master.

3 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ad7381b on develtech:package-meta into a41b025 on hellysmile:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ad7381b on develtech:package-meta into a41b025 on hellysmile:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ad7381b on develtech:package-meta into a41b025 on hellysmile:master.

@hellysmile
Copy link
Owner

hellysmile left a comment

Can You please change file opening way

setup.py Outdated
@@ -2,6 +2,11 @@

from setuptools import setup

about = {}
with open("django_activeurl/__about__.py") as fp:

This comment has been minimized.

@hellysmile

hellysmile Jul 27, 2017

Owner

io.open with explicit encoding and mode please

#show_authors = False
# package data
about = {}
with open("../django_activeurl/__about__.py") as fp:

This comment has been minimized.

@hellysmile

hellysmile Jul 27, 2017

Owner

io.open with explicit encoding and mode please

tony added some commits Jul 27, 2017

@tony

This comment has been minimized.

Copy link
Collaborator

tony commented Jul 27, 2017

Updated, mode='r' is default behavior in io.open on 2.7 and 3.3+. Do you want it added explicitly?

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 991654f on develtech:package-meta into a41b025 on hellysmile:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 991654f on develtech:package-meta into a41b025 on hellysmile:master.

@hellysmile hellysmile merged commit 6b4de93 into hellysmile:master Jul 27, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@hellysmile

This comment has been minimized.

Copy link
Owner

hellysmile commented Jul 27, 2017

just encoding is perfectly fine! thnx!

@tony tony deleted the develtech:package-meta branch Jul 27, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 991654f on develtech:package-meta into a41b025 on hellysmile:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment