Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use __about__ for package metadata on docs and setup #25

Merged
merged 3 commits into from Jul 27, 2017

Conversation

tony
Copy link
Collaborator

@tony tony commented Jul 27, 2017

This way, only one location needs to be updated for package versions/naming on docs/conf.py and setup.py.

@coveralls
Copy link

@coveralls coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ad7381b on develtech:package-meta into a41b025 on hellysmile:master.

3 similar comments
@coveralls
Copy link

@coveralls coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ad7381b on develtech:package-meta into a41b025 on hellysmile:master.

@coveralls
Copy link

@coveralls coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ad7381b on develtech:package-meta into a41b025 on hellysmile:master.

@coveralls
Copy link

@coveralls coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ad7381b on develtech:package-meta into a41b025 on hellysmile:master.

Copy link
Owner

@hellysmile hellysmile left a comment

Can You please change file opening way

setup.py Outdated
@@ -2,6 +2,11 @@

from setuptools import setup

about = {}
with open("django_activeurl/__about__.py") as fp:
Copy link
Owner

@hellysmile hellysmile Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

io.open with explicit encoding and mode please

docs/conf.py Outdated
#show_authors = False
# package data
about = {}
with open("../django_activeurl/__about__.py") as fp:
Copy link
Owner

@hellysmile hellysmile Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

io.open with explicit encoding and mode please

@tony
Copy link
Collaborator Author

@tony tony commented Jul 27, 2017

Updated, mode='r' is default behavior in io.open on 2.7 and 3.3+. Do you want it added explicitly?

@coveralls
Copy link

@coveralls coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 991654f on develtech:package-meta into a41b025 on hellysmile:master.

1 similar comment
@coveralls
Copy link

@coveralls coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 991654f on develtech:package-meta into a41b025 on hellysmile:master.

@hellysmile hellysmile merged commit 6b4de93 into hellysmile:master Jul 27, 2017
1 check was pending
@hellysmile
Copy link
Owner

@hellysmile hellysmile commented Jul 27, 2017

just encoding is perfectly fine! thnx!

@tony tony deleted the package-meta branch Jul 27, 2017
@coveralls
Copy link

@coveralls coveralls commented Jul 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 991654f on develtech:package-meta into a41b025 on hellysmile:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants