Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests #29

Merged
merged 8 commits into from Jul 27, 2017
Merged

Refactor tests #29

merged 8 commits into from Jul 27, 2017

Conversation

tony
Copy link
Collaborator

@tony tony commented Jul 27, 2017

No description provided.

@hellysmile
Copy link
Owner

@hellysmile hellysmile commented Jul 27, 2017

Can we get this geen in reafactoring branch?

@tony
Copy link
Collaborator Author

@tony tony commented Jul 27, 2017 •
edited

If we merge this into master, I'll merge it into / rebase it into #17 (my intention is that)

@hellysmile
Copy link
Owner

@hellysmile hellysmile commented Jul 27, 2017 •
edited

There is some missing statemets regarding django-extension
Also isort checks is missed

@hellysmile
Copy link
Owner

@hellysmile hellysmile commented Jul 27, 2017

You are welcome to merge it in refactoring directly

@tony
Copy link
Collaborator Author

@tony tony commented Jul 27, 2017

There is some missing statemets regarding django-extension

Can you explain this?

hellysmile
hellysmile reviewed Jul 27, 2017
View changes
tox.ini Outdated
commands =
flake8 --show-source django_activeurl
flake8
commands = flake8 django_extensions tests
Copy link
Owner

@hellysmile hellysmile Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is wrong package name statement

@hellysmile
Copy link
Owner

@hellysmile hellysmile commented Jul 27, 2017

What is safity and precommit?

@tony
Copy link
Collaborator Author

@tony tony commented Jul 27, 2017

Removed remnants of precommit, but safety is https://pypi.python.org/pypi/safety/1.5.1 (https://github.com/pyupio/safety)

Want to keep or remove?

@tony tony mentioned this pull request Jul 27, 2017
Merged
@hellysmile
Copy link
Owner

@hellysmile hellysmile commented Jul 27, 2017

Lets merge this to the master when it will becomes green

@hellysmile
Copy link
Owner

@hellysmile hellysmile commented Jul 27, 2017

As for me we can remove safity

@tony
Copy link
Collaborator Author

@tony tony commented Jul 27, 2017

Removed safety

@tony
Copy link
Collaborator Author

@tony tony commented Jul 27, 2017

Also, I slipped in a change from nose -> pytest in 07595ff

@tony tony merged commit a397fae into hellysmile:master Jul 27, 2017
1 check passed
@tony tony deleted the refactor-tests branch Jul 27, 2017
@tony tony mentioned this pull request Jul 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellysmile hellysmile

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tony @hellysmile