Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor tests #29
Conversation
tony
added some commits
Jul 27, 2017
This comment has been minimized.
This comment has been minimized.
|
Can we get this geen in reafactoring branch? |
This comment has been minimized.
This comment has been minimized.
|
If we merge this into master, I'll merge it into / rebase it into #17 (my intention is that) |
This comment has been minimized.
This comment has been minimized.
|
There is some missing statemets regarding django-extension |
This comment has been minimized.
This comment has been minimized.
|
You are welcome to merge it in refactoring directly |
This comment has been minimized.
This comment has been minimized.
Can you explain this? |
tony
force-pushed the
develtech:refactor-tests
branch
from
bf38199
to
97a554e
Jul 27, 2017
hellysmile
reviewed
Jul 27, 2017
| commands = | ||
| flake8 --show-source django_activeurl | ||
| flake8 | ||
| commands = flake8 django_extensions tests |
This comment has been minimized.
This comment has been minimized.
tony
force-pushed the
develtech:refactor-tests
branch
from
97a554e
to
3ebdab9
Jul 27, 2017
This comment has been minimized.
This comment has been minimized.
|
What is safity and precommit? |
tony
force-pushed the
develtech:refactor-tests
branch
from
a80819e
to
6dd1ebe
Jul 27, 2017
This comment has been minimized.
This comment has been minimized.
|
Removed remnants of precommit, but safety is https://pypi.python.org/pypi/safety/1.5.1 (https://github.com/pyupio/safety) Want to keep or remove? |
This comment has been minimized.
This comment has been minimized.
|
Lets merge this to the master when it will becomes green |
This comment has been minimized.
This comment has been minimized.
|
As for me we can remove safity |
tony
added some commits
Jul 27, 2017
tony
force-pushed the
develtech:refactor-tests
branch
from
ae5baeb
to
07595ff
Jul 27, 2017
This comment has been minimized.
This comment has been minimized.
|
Removed safety |
This comment has been minimized.
This comment has been minimized.
|
Also, I slipped in a change from nose -> pytest in 07595ff |
tony
added some commits
Jul 27, 2017
tony commentedJul 27, 2017
No description provided.