New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #29

Merged
merged 8 commits into from Jul 27, 2017

Conversation

Projects
None yet
2 participants
@tony
Copy link
Collaborator

tony commented Jul 27, 2017

No description provided.

@hellysmile

This comment has been minimized.

Copy link
Owner

hellysmile commented Jul 27, 2017

Can we get this geen in reafactoring branch?

@tony

This comment has been minimized.

Copy link
Collaborator

tony commented Jul 27, 2017

If we merge this into master, I'll merge it into / rebase it into #17 (my intention is that)

@hellysmile

This comment has been minimized.

Copy link
Owner

hellysmile commented Jul 27, 2017

There is some missing statemets regarding django-extension
Also isort checks is missed

@hellysmile

This comment has been minimized.

Copy link
Owner

hellysmile commented Jul 27, 2017

You are welcome to merge it in refactoring directly

@tony

This comment has been minimized.

Copy link
Collaborator

tony commented Jul 27, 2017

There is some missing statemets regarding django-extension

Can you explain this?

@tony tony force-pushed the develtech:refactor-tests branch from bf38199 to 97a554e Jul 27, 2017

tox.ini Outdated
commands =
flake8 --show-source django_activeurl
flake8
commands = flake8 django_extensions tests

This comment has been minimized.

@hellysmile

hellysmile Jul 27, 2017

Owner

Here is wrong package name statement

@tony tony force-pushed the develtech:refactor-tests branch from 97a554e to 3ebdab9 Jul 27, 2017

@hellysmile

This comment has been minimized.

Copy link
Owner

hellysmile commented Jul 27, 2017

What is safity and precommit?

@tony tony force-pushed the develtech:refactor-tests branch from a80819e to 6dd1ebe Jul 27, 2017

@tony

This comment has been minimized.

Copy link
Collaborator

tony commented Jul 27, 2017

Removed remnants of precommit, but safety is https://pypi.python.org/pypi/safety/1.5.1 (https://github.com/pyupio/safety)

Want to keep or remove?

@tony tony referenced this pull request Jul 27, 2017

Merged

Refactoring #17

@hellysmile

This comment has been minimized.

Copy link
Owner

hellysmile commented Jul 27, 2017

Lets merge this to the master when it will becomes green

@hellysmile

This comment has been minimized.

Copy link
Owner

hellysmile commented Jul 27, 2017

As for me we can remove safity

@tony tony force-pushed the develtech:refactor-tests branch from ae5baeb to 07595ff Jul 27, 2017

@tony

This comment has been minimized.

Copy link
Collaborator

tony commented Jul 27, 2017

Removed safety

@tony

This comment has been minimized.

Copy link
Collaborator

tony commented Jul 27, 2017

Also, I slipped in a change from nose -> pytest in 07595ff

tony added some commits Jul 27, 2017

@tony tony merged commit a397fae into hellysmile:master Jul 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tony tony deleted the develtech:refactor-tests branch Jul 27, 2017

@tony tony referenced this pull request Jul 27, 2017

Closed

Fix tox/testing matrix #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment