New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/stackdriver-exporter] fix duplicated 'livenessProbe', add 'readinessProbe' #10321

Merged
merged 3 commits into from Jan 2, 2019

Conversation

Projects
None yet
6 participants
@cristinanegrean
Copy link
Contributor

cristinanegrean commented Dec 31, 2018

@apenney

Which issue this PR fixes:

  • duplicated 'livenessProbe', add 'readinessProbe'
  • container environment variables introduced in chart version 0.0.5 cannot be overwritten and get empty defaults as of incorrect templating

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added the size/XS label Dec 31, 2018

@k8s-ci-robot k8s-ci-robot requested review from paulczar and sameersbn Dec 31, 2018

cristinanegrean added some commits Dec 31, 2018

cristinanegrean
Fixed duplicated livenessProbe. Added readinessProbe. Signed-off-by: …
…Cristina Negrean <hello@cristina.tech>

Signed-off-by: cristinanegrean <cristina.negrean@trifork.nl>
cristinanegrean
Updated chart version. Signed-off-by: Cristina Negrean <hello@cristin…
…a.tech>

Signed-off-by: cristinanegrean <cristina.negrean@trifork.nl>

@cristinanegrean cristinanegrean force-pushed the cristinanegrean:master branch from 4e81977 to 7d26539 Dec 31, 2018

@cristinanegrean cristinanegrean changed the title fix duplicated 'livenessProbe', add 'readinessProbe' [stable/stackdriver-exporter] fix duplicated 'livenessProbe', add 'readinessProbe' Dec 31, 2018

@cristinanegrean cristinanegrean changed the title [stable/stackdriver-exporter] fix duplicated 'livenessProbe', add 'readinessProbe' [stable/stackdriver-exporter]: fix duplicated 'livenessProbe', add 'readinessProbe' Dec 31, 2018

@cristinanegrean cristinanegrean changed the title [stable/stackdriver-exporter]: fix duplicated 'livenessProbe', add 'readinessProbe' [stable/stackdriver-exporter] : fix duplicated 'livenessProbe', add 'readinessProbe' Dec 31, 2018

@cristinanegrean cristinanegrean changed the title [stable/stackdriver-exporter] : fix duplicated 'livenessProbe', add 'readinessProbe' [stable/stackdriver-exporter] fix duplicated 'livenessProbe', add 'readinessProbe' Dec 31, 2018

@apenney

This comment has been minimized.

Copy link
Contributor

apenney commented Dec 31, 2018

Nice catch!

@davidkarlsen

This comment has been minimized.

Copy link
Member

davidkarlsen commented Jan 2, 2019

/ok-to-test
/lgtm
/assign

@cristinanegrean

This comment has been minimized.

Copy link
Contributor

cristinanegrean commented Jan 2, 2019

/retest

cristinanegrean
PR #10142 update stack driver-exporter to 0.6.0 with new options intr…
…oduces empty values for deployment env variables. Signed-off-by: Cristina Negrean <hello@cristina.tech>

Signed-off-by: cristinanegrean <cristina.negrean@trifork.nl>

@cristinanegrean cristinanegrean force-pushed the cristinanegrean:master branch from 6bb71f3 to 94ae7a5 Jan 2, 2019

@paulczar

This comment has been minimized.

Copy link
Collaborator

paulczar commented Jan 2, 2019

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristinanegrean, davidkarlsen, paulczar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [davidkarlsen,paulczar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 2, 2019

@k8s-ci-robot k8s-ci-robot merged commit f969a11 into helm:master Jan 2, 2019

5 checks passed

ci/circleci: lint-charts Your tests passed on CircleCI!
Details
ci/circleci: lint-scripts Your tests passed on CircleCI!
Details
dco-labeler All commits have signoff
pull-charts-e2e Job succeeded.
Details
tide In merge pool.
Details

ivanmp91 pushed a commit to softonic/charts that referenced this pull request Jan 3, 2019

[stable/stackdriver-exporter] fix duplicated 'livenessProbe', add 're…
…adinessProbe' (helm#10321)

* Fixed duplicated livenessProbe. Added readinessProbe. Signed-off-by: Cristina Negrean <hello@cristina.tech>

Signed-off-by: cristinanegrean <cristina.negrean@trifork.nl>

* Updated chart version. Signed-off-by: Cristina Negrean <hello@cristina.tech>

Signed-off-by: cristinanegrean <cristina.negrean@trifork.nl>

* PR helm#10142 update stack driver-exporter to 0.6.0 with new options introduces empty values for deployment env variables. Signed-off-by: Cristina Negrean <hello@cristina.tech>

Signed-off-by: cristinanegrean <cristina.negrean@trifork.nl>
Signed-off-by: Iván Mora <ivan.mora@ST-A135-5LLG8WP.domino.softonic.com>

ivanmp91 pushed a commit to softonic/charts that referenced this pull request Jan 3, 2019

[stable/stackdriver-exporter] fix duplicated 'livenessProbe', add 're…
…adinessProbe' (helm#10321)

* Fixed duplicated livenessProbe. Added readinessProbe. Signed-off-by: Cristina Negrean <hello@cristina.tech>

Signed-off-by: cristinanegrean <cristina.negrean@trifork.nl>

* Updated chart version. Signed-off-by: Cristina Negrean <hello@cristina.tech>

Signed-off-by: cristinanegrean <cristina.negrean@trifork.nl>

* PR helm#10142 update stack driver-exporter to 0.6.0 with new options introduces empty values for deployment env variables. Signed-off-by: Cristina Negrean <hello@cristina.tech>

Signed-off-by: cristinanegrean <cristina.negrean@trifork.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment