Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/stackdriver-exporter] fix duplicated 'livenessProbe', add 'readinessProbe' #10321

Merged
merged 3 commits into from Jan 2, 2019

Conversation

@cristinanegrean
Copy link
Contributor

@cristinanegrean cristinanegrean commented Dec 31, 2018

@apenney

Which issue this PR fixes:

  • duplicated 'livenessProbe', add 'readinessProbe'
  • container environment variables introduced in chart version 0.0.5 cannot be overwritten and get empty defaults as of incorrect templating

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
cristinanegrean added 2 commits Dec 31, 2018
…Cristina Negrean <hello@cristina.tech>

Signed-off-by: cristinanegrean <cristina.negrean@trifork.nl>
…a.tech>

Signed-off-by: cristinanegrean <cristina.negrean@trifork.nl>
@cristinanegrean cristinanegrean changed the title fix duplicated 'livenessProbe', add 'readinessProbe' [stable/stackdriver-exporter] fix duplicated 'livenessProbe', add 'readinessProbe' Dec 31, 2018
@cristinanegrean cristinanegrean changed the title [stable/stackdriver-exporter] fix duplicated 'livenessProbe', add 'readinessProbe' [stable/stackdriver-exporter]: fix duplicated 'livenessProbe', add 'readinessProbe' Dec 31, 2018
@cristinanegrean cristinanegrean changed the title [stable/stackdriver-exporter]: fix duplicated 'livenessProbe', add 'readinessProbe' [stable/stackdriver-exporter] : fix duplicated 'livenessProbe', add 'readinessProbe' Dec 31, 2018
@cristinanegrean cristinanegrean changed the title [stable/stackdriver-exporter] : fix duplicated 'livenessProbe', add 'readinessProbe' [stable/stackdriver-exporter] fix duplicated 'livenessProbe', add 'readinessProbe' Dec 31, 2018
@apenney
Copy link
Contributor

@apenney apenney commented Dec 31, 2018

Nice catch!

@davidkarlsen
Copy link
Member

@davidkarlsen davidkarlsen commented Jan 2, 2019

/ok-to-test
/lgtm
/assign

@cristinanegrean
Copy link
Contributor Author

@cristinanegrean cristinanegrean commented Jan 2, 2019

/retest

…introduces empty values for deployment env variables. Signed-off-by: Cristina Negrean <hello@cristina.tech>

Signed-off-by: cristinanegrean <cristina.negrean@trifork.nl>
@paulczar
Copy link
Collaborator

@paulczar paulczar commented Jan 2, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jan 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristinanegrean, davidkarlsen, paulczar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [davidkarlsen,paulczar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f969a11 into helm:master Jan 2, 2019
6 checks passed
wgiddens added a commit to wgiddens/charts that referenced this issue Jan 18, 2019
…adinessProbe' (helm#10321)

* Fixed duplicated livenessProbe. Added readinessProbe. Signed-off-by: Cristina Negrean <hello@cristina.tech>

Signed-off-by: cristinanegrean <cristina.negrean@trifork.nl>

* Updated chart version. Signed-off-by: Cristina Negrean <hello@cristina.tech>

Signed-off-by: cristinanegrean <cristina.negrean@trifork.nl>

* PR helm#10142 update stack driver-exporter to 0.6.0 with new options introduces empty values for deployment env variables. Signed-off-by: Cristina Negrean <hello@cristina.tech>

Signed-off-by: cristinanegrean <cristina.negrean@trifork.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants