Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-operator] Prometheus operator version updates #10684

Merged

Conversation

DerekHeldtWerle
Copy link
Contributor

Signed-off-by: Derek Heldt-Werle derek.heldt-werle@viasat.com

What this PR does / why we need it:

Updates the grafana dependency to allow use of extraConfigmapMounts and the kube-state-metrics dependency for the use of a podsecuritypolicy.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Jan 16, 2019
@DerekHeldtWerle DerekHeldtWerle changed the title Prometheus operator version updates [stable/prometheus-operator] Prometheus operator version updates Jan 16, 2019
Copy link
Contributor

@paskal paskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please include newly supported options in readme and maybe values.yaml please?

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2019
@DerekHeldtWerle
Copy link
Contributor Author

/assign @gianrubio

Copy link
Collaborator

@gianrubio gianrubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 17, 2019
@helm-bot helm-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2019
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2019
@DerekHeldtWerle DerekHeldtWerle force-pushed the prometheus-operator-version-updates branch from da076df to 55a1c12 Compare January 17, 2019 17:05
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 17, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2019
@DerekHeldtWerle
Copy link
Contributor Author

@gianrubio Looks like I lost the race for the chart version. I've since bumped it, but let me know if you need anything else from my end. Thanks!

Copy link
Collaborator

@gianrubio gianrubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2019
Signed-off-by: Derek Heldt-Werle <derek.heldt-werle@viasat.com>
Signed-off-by: Derek Heldt-Werle <derek.heldt-werle@viasat.com>
Signed-off-by: Derek Heldt-Werle <derek.heldt-werle@viasat.com>
@DerekHeldtWerle DerekHeldtWerle force-pushed the prometheus-operator-version-updates branch from 55a1c12 to 0df7a65 Compare January 24, 2019 16:33
@helm-bot helm-bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 24, 2019
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 24, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2019
@gianrubio
Copy link
Collaborator

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DerekHeldtWerle, gianrubio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6340adb into helm:master Jan 24, 2019
syedimam0012 pushed a commit to syedimam0012/charts that referenced this pull request Jan 30, 2019
…m#10684)

* Updated grafana dep for extraConfigmapMounts, kube-state-metrics for psp

Signed-off-by: Derek Heldt-Werle <derek.heldt-werle@viasat.com>

* Added newly supported options to both the README and values.yaml file

Signed-off-by: Derek Heldt-Werle <derek.heldt-werle@viasat.com>

* Bump version number

Signed-off-by: Derek Heldt-Werle <derek.heldt-werle@viasat.com>
Signed-off-by: Syed Imam <syedimam0012@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants