New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nextcloud chart #10922

Merged
merged 4 commits into from Feb 11, 2019

Conversation

@chrisingenhaag
Copy link
Contributor

chrisingenhaag commented Jan 26, 2019

What this PR does / why we need it:

This PR adds nextcloud to helm stable. It´s inspired from affix´ PR #5180 which is now stale for about half a year. Thx for his work on this point.

Nevertheless I wanted to get this done, refactored the chart and created a new PR fro it.

  • corrected nextcloud image env var usage
  • default helm install uses nextclouds integrated sqllite db with env-var-based auto-configuration
  • updated to use up to date mariadb chart optionally
  • simplified pvc usage with one pv and volume subPath-usage
  • inserted test-connection Pod

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@k8s-ci-robot k8s-ci-robot requested review from mattfarina and sameersbn Jan 26, 2019

@chrisingenhaag chrisingenhaag force-pushed the chrisingenhaag:nextcloud branch from 755baf1 to 63c46e2 Jan 26, 2019

@helm-bot helm-bot added size/XL and removed size/XL labels Jan 26, 2019

@chrisingenhaag chrisingenhaag force-pushed the chrisingenhaag:nextcloud branch from 63c46e2 to 4ff0f18 Jan 26, 2019

@helm-bot helm-bot added size/XL and removed size/XL labels Jan 26, 2019

add nextcloud chart
Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>

@chrisingenhaag chrisingenhaag force-pushed the chrisingenhaag:nextcloud branch from 4ff0f18 to f4bb1a9 Jan 26, 2019

@helm-bot helm-bot added size/XL and removed size/XL labels Jan 26, 2019

@chrisingenhaag

This comment has been minimized.

Copy link
Contributor Author

chrisingenhaag commented Jan 26, 2019

/assign unguiculus

insert suggestions from reviews in #5180
Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>

@helm-bot helm-bot added size/XL and removed size/XL labels Jan 27, 2019

disable ingress per default
Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>

@helm-bot helm-bot added size/XL and removed size/XL labels Jan 27, 2019

@anarcat
Copy link

anarcat left a comment

i haven't re-reviewed everything, but I made sure the comments from the previous PR were addressed, so I'd put a LGTM here.. :)

@unguiculus

This comment has been minimized.

Copy link
Member

unguiculus commented Feb 8, 2019

/ok-to-test

fix nextcloud e2e tests
Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>

@helm-bot helm-bot added size/XL and removed size/XL labels Feb 8, 2019

@chrisingenhaag

This comment has been minimized.

Copy link
Contributor Author

chrisingenhaag commented Feb 9, 2019

/retest

@unguiculus

This comment has been minimized.

Copy link
Member

unguiculus commented Feb 11, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisingenhaag, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e41880e into helm:master Feb 11, 2019

5 checks passed

ci/circleci: lint-charts Your tests passed on CircleCI!
Details
ci/circleci: lint-scripts Your tests passed on CircleCI!
Details
dco-labeler All commits have signoff
pull-charts-e2e Job succeeded.
Details
tide In merge pool.
Details

tbuchier added a commit to tbuchier/charts that referenced this pull request Feb 14, 2019

add nextcloud chart (helm#10922)
* add nextcloud chart

Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>

* insert suggestions from reviews in helm#5180

Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>

* disable ingress per default

Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>

* fix nextcloud e2e tests

Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment