Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

add nextcloud chart #10922

Merged
merged 4 commits into from
Feb 11, 2019
Merged

add nextcloud chart #10922

merged 4 commits into from
Feb 11, 2019

Conversation

chrisingenhaag
Copy link
Collaborator

@chrisingenhaag chrisingenhaag commented Jan 26, 2019 •
edited
Loading

What this PR does / why we need it:

This PR adds nextcloud to helm stable. It´s inspired from affix´ PR #5180 which is now stale for about half a year. Thx for his work on this point.

Nevertheless I wanted to get this done, refactored the chart and created a new PR fro it.

  • corrected nextcloud image env var usage
  • default helm install uses nextclouds integrated sqllite db with env-var-based auto-configuration
  • updated to use up to date mariadb chart optionally
  • simplified pvc usage with one pv and volume subPath-usage
  • inserted test-connection Pod

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 26, 2019
@helm-bot helm-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 26, 2019
@helm-bot helm-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 26, 2019
@chrisingenhaag
add nextcloud chart
f4bb1a9 
Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>
@helm-bot helm-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 26, 2019
@chrisingenhaag
Copy link
Collaborator Author

/assign unguiculus

@chrisingenhaag chrisingenhaag mentioned this pull request Jan 27, 2019
Closed
@chrisingenhaag
insert suggestions from reviews in helm#5180
3fb125f 
Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>
@helm-bot helm-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 27, 2019
@chrisingenhaag
disable ingress per default
e74fd28 
Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>
@helm-bot helm-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 27, 2019
anarcat
anarcat approved these changes Jan 27, 2019
View reviewed changes
Copy link

@anarcat anarcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i haven't re-reviewed everything, but I made sure the comments from the previous PR were addressed, so I'd put a LGTM here.. :)

This was referenced Jan 28, 2019
Closed
Closed
@unguiculus
Copy link
Member

/ok-to-test

@chrisingenhaag
fix nextcloud e2e tests
2c83074 
Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>
@helm-bot helm-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 8, 2019
@chrisingenhaag
Copy link
Collaborator Author

/retest

@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisingenhaag, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit e41880e into helm:master Feb 11, 2019
@chrisingenhaag chrisingenhaag mentioned this pull request Feb 11, 2019
Merged
3 tasks
tbuchier pushed a commit to tbuchier/charts that referenced this pull request Feb 14, 2019
@chrisingenhaag @tbuchier
add nextcloud chart (helm#10922)
9109390 
* add nextcloud chart

Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>

* insert suggestions from reviews in helm#5180

Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>

* disable ingress per default

Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>

* fix nextcloud e2e tests

Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>
@m-ueberall m-ueberall mentioned this pull request Feb 26, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aixeshunter aixeshunter aixeshunter approved these changes

@anarcat anarcat anarcat approved these changes

@mattfarina mattfarina Awaiting requested review from mattfarina

@sameersbn sameersbn Awaiting requested review from sameersbn

Assignees

@unguiculus unguiculus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chrisingenhaag @unguiculus @k8s-ci-robot @anarcat @aixeshunter @helm-bot