Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/prometheus-node-exporter] Add options to change volume mount propagation #11194

Merged
merged 2 commits into from Feb 18, 2019

Conversation

@kaarolch
Copy link
Contributor

commented Feb 6, 2019

Signed-off-by: Karol Chrapek kaarol@it-flow.pl

What this PR does / why we need it:

This PR allow to mount volume inside node exporter with rslave option - in kubernetes mountPropagation. This is useful when you would like to monitoring dynamic mounting volumes.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
Add options to change volume mount propagation
Signed-off-by: Karol Chrapek <kaarol@it-flow.pl>
Add missing new line
Signed-off-by: Karol Chrapek <kaarol@it-flow.pl>

@helm-bot helm-bot added size/S and removed size/S labels Feb 6, 2019

@kaarolch

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2019

/assign @gianrubio

@kaarolch

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2019

@cpanato or @gianrubio do you have any concern regaring mountPropagation?

@kaarolch

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2019

@gianrubio any chance to merge this PR?

@gianrubio
Copy link
Collaborator

left a comment

/ok-to-test
/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gianrubio, kaarolch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b032d01 into helm:master Feb 18, 2019

6 checks passed

DCO DCO
Details
ci/circleci: lint-charts Your tests passed on CircleCI!
Details
ci/circleci: lint-scripts Your tests passed on CircleCI!
Details
dco-labeler All commits have signoff
pull-charts-e2e Job succeeded.
Details
tide In merge pool.
Details

@kaarolch kaarolch deleted the novomatic-tech:feature/node_exporter branch Feb 18, 2019

@kaarolch kaarolch referenced this pull request Feb 18, 2019
2 of 3 tasks complete

Dariusch pushed a commit to Dariusch/charts that referenced this pull request Mar 4, 2019

[stable/prometheus-node-exporter] Add options to change volume mount …
…propagation (helm#11194)

* Add options to change volume  mount propagation

Signed-off-by: Karol Chrapek <kaarol@it-flow.pl>

* Add missing new line

Signed-off-by: Karol Chrapek <kaarol@it-flow.pl>

PierluigiLenociAkelius added a commit to PierluigiLenociAkelius/charts that referenced this pull request Apr 25, 2019

[stable/prometheus-node-exporter] Add options to change volume mount …
…propagation (helm#11194)

* Add options to change volume  mount propagation

Signed-off-by: Karol Chrapek <kaarol@it-flow.pl>

* Add missing new line

Signed-off-by: Karol Chrapek <kaarol@it-flow.pl>
Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@akelius.de>

alexey-medvedchikov added a commit to alexey-medvedchikov/charts that referenced this pull request May 16, 2019

alexey-medvedchikov added a commit to alexey-medvedchikov/charts that referenced this pull request May 16, 2019

alexey-medvedchikov added a commit to alexey-medvedchikov/charts that referenced this pull request May 16, 2019

[stable/prometheus] Add options to change volume mount propagation (s…
…ame as helm#11194 for prometheus-node-exporter)

Signed-off-by: Alexey Medvedchikov <alexey.medvedchikov@gmail.com>

alexey-medvedchikov added a commit to alexey-medvedchikov/charts that referenced this pull request May 16, 2019

[stable/prometheus] Add options to change volume mount propagation (s…
…ame as helm#11194 for prometheus-node-exporter)

Signed-off-by: Alexey Medvedchikov <alexey.medvedchikov@gmail.com>

alexey-medvedchikov added a commit to alexey-medvedchikov/charts that referenced this pull request Jul 1, 2019

[stable/prometheus] Add options to change volume mount propagation (s…
…ame as helm#11194 for prometheus-node-exporter)

Signed-off-by: Alexey Medvedchikov <alexey.medvedchikov@gmail.com>

concourse-bot pushed a commit to concourse/charts that referenced this pull request Aug 13, 2019

[stable/prometheus] Add options to change volume mount propagation (s…
…ame as helm#11194 for prometheus-node-exporter) (helm#13922)

Signed-off-by: Alexey Medvedchikov <alexey.medvedchikov@gmail.com>

ThoTischner pushed a commit to bitsbeats/charts that referenced this pull request Aug 13, 2019

[stable/prometheus] Add options to change volume mount propagation (s…
…ame as helm#11194 for prometheus-node-exporter) (helm#13922)

Signed-off-by: Alexey Medvedchikov <alexey.medvedchikov@gmail.com>

mogaal added a commit to mogaal/charts that referenced this pull request Aug 15, 2019

[stable/prometheus] Add options to change volume mount propagation (s…
…ame as helm#11194 for prometheus-node-exporter) (helm#13922)

Signed-off-by: Alexey Medvedchikov <alexey.medvedchikov@gmail.com>

mogaal added a commit to mogaal/charts that referenced this pull request Aug 15, 2019

[stable/prometheus] Add options to change volume mount propagation (s…
…ame as helm#11194 for prometheus-node-exporter) (helm#13922)

Signed-off-by: Alexey Medvedchikov <alexey.medvedchikov@gmail.com>

rolandg added a commit to rolandg/charts that referenced this pull request Aug 19, 2019

[stable/prometheus] Add options to change volume mount propagation (s…
…ame as helm#11194 for prometheus-node-exporter) (helm#13922)

Signed-off-by: Alexey Medvedchikov <alexey.medvedchikov@gmail.com>
Signed-off-by: Roland Gritzer <gritzer.roland@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.