Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/external-dns] Support DigitalOcean (Fixes #10923). #11257

Merged
merged 4 commits into from
Feb 27, 2019

Conversation

andrewsomething
Copy link
Contributor

No description provided.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Feb 8, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @andrewsomething. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 8, 2019
Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2019
@mattfarina
Copy link
Contributor

/ok-to-test

@blancsys
Copy link

@mattfarina Hi, can this PR be merged? Thanks

@mattfarina
Copy link
Contributor

/ok-to-test

It seems the hook wasn't caught before.

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2019
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Feb 26, 2019
Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 26, 2019
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 26, 2019
@mattfarina
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsomething, mattfarina

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2dabf16 into helm:master Feb 27, 2019
monotek pushed a commit to monotek/charts that referenced this pull request Mar 7, 2019
…11257)

* [stable/external-dns] Support DigitalOcean (Fixes helm#10923).

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>

* [stable/external-dns] Bump chart version.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>

* [stable/external-dns] Bump chart version again.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
alvgarvilla pushed a commit to alvgarvilla/charts that referenced this pull request Mar 13, 2019
…11257)

* [stable/external-dns] Support DigitalOcean (Fixes helm#10923).

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>

* [stable/external-dns] Bump chart version.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>

* [stable/external-dns] Bump chart version again.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
rmccorm4 pushed a commit to rmccorm4/charts that referenced this pull request Mar 26, 2019
…11257)

* [stable/external-dns] Support DigitalOcean (Fixes helm#10923).

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>

* [stable/external-dns] Bump chart version.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>

* [stable/external-dns] Bump chart version again.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
devnulled pushed a commit to devnulled/charts that referenced this pull request Apr 25, 2019
…11257)

* [stable/external-dns] Support DigitalOcean (Fixes helm#10923).

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>

* [stable/external-dns] Bump chart version.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>

* [stable/external-dns] Bump chart version again.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants