This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/external-dns] Support DigitalOcean (Fixes #10923). #11257
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
helm-bot
added
size/S
|
Hi @andrewsomething. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
helm-bot
added
size/S
|
/ok-to-test |
|
@mattfarina Hi, can this PR be merged? Thanks |
|
/ok-to-test It seems the hook wasn't caught before. |
k8s-ci-robot
added
ok-to-test
and removed
needs-ok-to-test
helm-bot
added
size/S
Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
andrewsomething
force-pushed
the
master
branch
from
d6258bf
to
0c99702
Compare
helm-bot
added
Contribution Allowed
helm-bot
added
size/S
mattfarina
approved these changes
Feb 27, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsomething, mattfarina The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
monotek
pushed a commit
to monotek/charts
that referenced
this pull request
Mar 7, 2019
…11257) * [stable/external-dns] Support DigitalOcean (Fixes helm#10923). Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com> * [stable/external-dns] Bump chart version. Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com> * [stable/external-dns] Bump chart version again. Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
alvgarvilla
pushed a commit
to alvgarvilla/charts
that referenced
this pull request
Mar 13, 2019
…11257) * [stable/external-dns] Support DigitalOcean (Fixes helm#10923). Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com> * [stable/external-dns] Bump chart version. Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com> * [stable/external-dns] Bump chart version again. Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
rmccorm4
pushed a commit
to rmccorm4/charts
that referenced
this pull request
Mar 26, 2019
…11257) * [stable/external-dns] Support DigitalOcean (Fixes helm#10923). Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com> * [stable/external-dns] Bump chart version. Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com> * [stable/external-dns] Bump chart version again. Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
devnulled
pushed a commit
to devnulled/charts
that referenced
this pull request
Apr 25, 2019
…11257) * [stable/external-dns] Support DigitalOcean (Fixes helm#10923). Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com> * [stable/external-dns] Bump chart version. Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com> * [stable/external-dns] Bump chart version again. Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.