Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/external-dns] Support DigitalOcean (Fixes #10923). #11257

Merged
merged 4 commits into from Feb 27, 2019

Conversation

@andrewsomething
Copy link
Contributor

@andrewsomething andrewsomething commented Feb 8, 2019

No description provided.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Feb 8, 2019

Hi @andrewsomething. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
@helm-bot helm-bot added size/S and removed size/S labels Feb 8, 2019
@mattfarina
Copy link
Contributor

@mattfarina mattfarina commented Feb 15, 2019

/ok-to-test

@blancsys
Copy link

@blancsys blancsys commented Feb 20, 2019

@mattfarina Hi, can this PR be merged? Thanks

@mattfarina
Copy link
Contributor

@mattfarina mattfarina commented Feb 26, 2019

/ok-to-test

It seems the hook wasn't caught before.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
@helm-bot helm-bot added size/S and removed size/S labels Feb 26, 2019
@mattfarina
Copy link
Contributor

@mattfarina mattfarina commented Feb 27, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Feb 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsomething, mattfarina

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2dabf16 into helm:master Feb 27, 2019
6 checks passed
6 checks passed
@dco
DCO DCO
Details
ci/circleci: lint-charts Your tests passed on CircleCI!
Details
ci/circleci: lint-scripts Your tests passed on CircleCI!
Details
@helm-bot
dco-labeler All commits have signoff
@k8s-ci-robot
pull-charts-e2e Job succeeded.
Details
@k8s-ci-robot
tide In merge pool.
Details
monotek pushed a commit to monotek/charts that referenced this pull request Mar 7, 2019
…11257)

* [stable/external-dns] Support DigitalOcean (Fixes helm#10923).

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>

* [stable/external-dns] Bump chart version.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>

* [stable/external-dns] Bump chart version again.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
alvgarvilla added a commit to alvgarvilla/charts that referenced this pull request Mar 13, 2019
…11257)

* [stable/external-dns] Support DigitalOcean (Fixes helm#10923).

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>

* [stable/external-dns] Bump chart version.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>

* [stable/external-dns] Bump chart version again.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
rmccorm4 added a commit to rmccorm4/charts that referenced this pull request Mar 26, 2019
…11257)

* [stable/external-dns] Support DigitalOcean (Fixes helm#10923).

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>

* [stable/external-dns] Bump chart version.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>

* [stable/external-dns] Bump chart version again.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
devnulled added a commit to devnulled/charts that referenced this pull request Apr 25, 2019
…11257)

* [stable/external-dns] Support DigitalOcean (Fixes helm#10923).

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>

* [stable/external-dns] Bump chart version.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>

* [stable/external-dns] Bump chart version again.

Signed-off-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants