Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tolerations to efs-provisioner #12021

Merged
merged 2 commits into from Mar 18, 2019

Conversation

Projects
None yet
4 participants
@cpoole
Copy link
Contributor

commented Mar 8, 2019

What this PR does / why we need it:

Adding tolerations to efs-provisioner

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@k8s-ci-robot k8s-ci-robot requested review from prydonius and scottrigby Mar 8, 2019

@helm-bot helm-bot added the size/S label Mar 8, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

Hi @cpoole. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpoole cpoole force-pushed the cpoole:efs branch from af21aa9 to ea46aab Mar 8, 2019

@cpoole cpoole force-pushed the cpoole:efs branch from ea46aab to e3cfde3 Mar 8, 2019

@helm-bot helm-bot added size/S and removed size/S labels Mar 8, 2019

@hareku

This comment has been minimized.

Copy link
Collaborator

commented Mar 18, 2019

@cpoole Thank you for your PR.
Would you bump a Chart version? (current version is 0.3.2)

cpoole added some commits Mar 8, 2019

added tolerations to efs-provisioner
Signed-off-by: Connor Poole <connor.poole@gmail.com>
bump chart
Signed-off-by: Connor Poole <connor.poole@gmail.com>

@cpoole cpoole force-pushed the cpoole:efs branch from ab4a2d6 to 56b72b7 Mar 18, 2019

@cpoole

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

rebased and bumped @hareku

@hareku

This comment has been minimized.

Copy link
Collaborator

commented Mar 18, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 18, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpoole, hareku

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hareku

This comment has been minimized.

Copy link
Collaborator

commented Mar 18, 2019

/ok-to-test

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

@hareku: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 591ff25 into helm:master Mar 18, 2019

6 checks passed

DCO DCO
Details
ci/circleci: lint-charts Your tests passed on CircleCI!
Details
ci/circleci: lint-scripts Your tests passed on CircleCI!
Details
dco-labeler All commits have signoff
pull-charts-e2e Job succeeded.
Details
tide In merge pool.
Details

rmccorm4 added a commit to rmccorm4/charts that referenced this pull request Mar 26, 2019

added tolerations to efs-provisioner (helm#12021)
* added tolerations to efs-provisioner

Signed-off-by: Connor Poole <connor.poole@gmail.com>

* bump chart

Signed-off-by: Connor Poole <connor.poole@gmail.com>

crackmac pushed a commit to crackmac/charts that referenced this pull request Mar 29, 2019

added tolerations to efs-provisioner (helm#12021)
* added tolerations to efs-provisioner

Signed-off-by: Connor Poole <connor.poole@gmail.com>

* bump chart

Signed-off-by: Connor Poole <connor.poole@gmail.com>

crackmac pushed a commit to crackmac/charts that referenced this pull request Mar 29, 2019

added tolerations to efs-provisioner (helm#12021)
* added tolerations to efs-provisioner

Signed-off-by: Connor Poole <connor.poole@gmail.com>

* bump chart

Signed-off-by: Connor Poole <connor.poole@gmail.com>
Signed-off-by: Kevin Duane <duank001@apps.disney.com>

PierluigiLenociAkelius added a commit to PierluigiLenociAkelius/charts that referenced this pull request Apr 25, 2019

added tolerations to efs-provisioner (helm#12021)
* added tolerations to efs-provisioner

Signed-off-by: Connor Poole <connor.poole@gmail.com>

* bump chart

Signed-off-by: Connor Poole <connor.poole@gmail.com>
Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@akelius.de>

devnulled added a commit to devnulled/charts that referenced this pull request Apr 25, 2019

added tolerations to efs-provisioner (helm#12021)
* added tolerations to efs-provisioner

Signed-off-by: Connor Poole <connor.poole@gmail.com>

* bump chart

Signed-off-by: Connor Poole <connor.poole@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.