New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry chart #1226

Merged
merged 21 commits into from Jun 15, 2017

Conversation

Projects
None yet
7 participants
@rothgar
Contributor

rothgar commented Jun 2, 2017

My first chart. Still in progress. Feedback welcome.

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Jun 2, 2017

Contributor

Hi @rothgar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Jun 2, 2017

Hi @rothgar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rothgar

This comment has been minimized.

Show comment
Hide comment
@rothgar

rothgar Jun 2, 2017

Contributor

Trying to install for testing. Ran

helm dep build
helm install --debug .

Seeing errors

Created tunnel using local port: '36815'
SERVER: "localhost:36815"
CHART PATH: /home/jgarr/src/kubernetes/charts/incubator/sentry
Error: release xrayed-terrier failed: deployments.extensions "xrayed-terrier-sentry" already exists

This is a brand new GKE cluster for testing

$ helm version
Client: &version.Version{SemVer:"v2.2.3", GitCommit:"1402a4d6ec9fb349e17b912e32fe259ca21181e3", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.2.3", GitCommit:"1402a4d6ec9fb349e17b912e32fe259ca21181e3", GitTreeState:"clean"}

Any thoughts?
@lachie83

Contributor

rothgar commented Jun 2, 2017

Trying to install for testing. Ran

helm dep build
helm install --debug .

Seeing errors

Created tunnel using local port: '36815'
SERVER: "localhost:36815"
CHART PATH: /home/jgarr/src/kubernetes/charts/incubator/sentry
Error: release xrayed-terrier failed: deployments.extensions "xrayed-terrier-sentry" already exists

This is a brand new GKE cluster for testing

$ helm version
Client: &version.Version{SemVer:"v2.2.3", GitCommit:"1402a4d6ec9fb349e17b912e32fe259ca21181e3", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.2.3", GitCommit:"1402a4d6ec9fb349e17b912e32fe259ca21181e3", GitTreeState:"clean"}

Any thoughts?
@lachie83

Show outdated Hide outdated incubator/sentry/values.yaml Outdated
@lachie83

This comment has been minimized.

Show comment
Hide comment
@lachie83

lachie83 Jun 2, 2017

Contributor

@rothgar This PR is great to see. This issue is because both the web, worker and cron deployments are being generated with the same name. Try appending the component name to the end. Here's an example -- https://github.com/kubernetes/charts/blob/master/incubator/istio/templates/manager-deployment.yaml#L5. You could also do something like name: {{ template "fullname" . }}-worker

Contributor

lachie83 commented Jun 2, 2017

@rothgar This PR is great to see. This issue is because both the web, worker and cron deployments are being generated with the same name. Try appending the component name to the end. Here's an example -- https://github.com/kubernetes/charts/blob/master/incubator/istio/templates/manager-deployment.yaml#L5. You could also do something like name: {{ template "fullname" . }}-worker

@lachie83

This comment has been minimized.

Show comment
Hide comment
@lachie83

lachie83 Jun 2, 2017

Contributor

I got this chart to install with the following changes

~/sandbox/kubernetes/charts/incubator/sentry on pr/1226 [!]
$ git d
 incubator/sentry/requirements.lock                 |  6 ++++--
 incubator/sentry/templates/cron-deployment.yaml    |  2 +-
 incubator/sentry/templates/workers-deployment.yaml |  2 +-
 incubator/sentry/values.yaml                       | 20 ++++++++++----------
 4 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/incubator/sentry/requirements.lock b/incubator/sentry/requirements.lock
index 581a112..5679370 100644
--- a/incubator/sentry/requirements.lock
+++ b/incubator/sentry/requirements.lock
@@ -1,15 +1,17 @@
 dependencies:
 - condition: ""
   enabled: false
+  import-values: null
   name: postgresql
   repository: https://kubernetes-charts.storage.googleapis.com/
   tags: null
   version: 0.7.1
 - condition: ""
   enabled: false
+  import-values: null
   name: redis
   repository: https://kubernetes-charts.storage.googleapis.com/
   tags: null
   version: 0.6.0
-digest: sha256:ea6510a357c699082e455250d166978c363f420ee8d589c48492e83b4c376eba
-generated: 2017-06-02T06:18:46.211627938Z
+digest: sha256:dbaa80dbd8326dc559176f3bb5c97723b5a9c6378cd5b01fe3d0787825de9bac
+generated: 2017-06-02T10:11:05.87979944-07:00
diff --git a/incubator/sentry/templates/cron-deployment.yaml b/incubator/sentry/templates/cron-deployment.yaml
index ae212fc..94b9c25 100644
--- a/incubator/sentry/templates/cron-deployment.yaml
+++ b/incubator/sentry/templates/cron-deployment.yaml
@@ -1,7 +1,7 @@
 apiVersion: extensions/v1beta1
 kind: Deployment
 metadata:
-  name: {{ template "fullname" . }}
+  name: {{ template "fullname" . }}-cron
   labels:
     chart: "{{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}"
 spec:
diff --git a/incubator/sentry/templates/workers-deployment.yaml b/incubator/sentry/templates/workers-deployment.yaml
index 374004b..ed1862b 100644
--- a/incubator/sentry/templates/workers-deployment.yaml
+++ b/incubator/sentry/templates/workers-deployment.yaml
@@ -1,7 +1,7 @@
 apiVersion: extensions/v1beta1
 kind: Deployment
 metadata:
-  name: {{ template "fullname" . }}
+  name: {{ template "fullname" . }}-worker
   labels:
     chart: "{{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}"
 spec:
diff --git a/incubator/sentry/values.yaml b/incubator/sentry/values.yaml
index 6006b51..08b929d 100644
--- a/incubator/sentry/values.yaml
+++ b/incubator/sentry/values.yaml
@@ -21,17 +21,17 @@ resources:
     cpu: 100m
     memory: 128Mi

-  ## Enable persistence using Persistent Volume Claims
-  ## ref: http://kubernetes.io/docs/user-guide/persistent-volumes/
+## Enable persistence using Persistent Volume Claims
+## ref: http://kubernetes.io/docs/user-guide/persistent-volumes/
+##
+persistence:
+  enabled: false
+  ## If defined, volume.beta.kubernetes.io/storage-class: <storageClass>
+  ## Default: volume.alpha.kubernetes.io/storage-class: default
   ##
-  persistence:
-    enabled: false
-    ## If defined, volume.beta.kubernetes.io/storage-class: <storageClass>
-    ## Default: volume.alpha.kubernetes.io/storage-class: default
-    ##
-    # storageClass:
-    accessMode: ReadWriteOnce
-    size: 8Gi
+  # storageClass:
+  accessMode: ReadWriteOnce
+  size: 8Gi

 ## Configure ingress resource that allow you to access the
 ## Sentry instalation. Set up the URL
~/sandbox/kubernetes/charts/incubator/sentry on pr/1226 [!]
$ helm install .
NAME:   agile-gibbon
LAST DEPLOYED: Fri Jun  2 10:21:44 2017
NAMESPACE: default
STATUS: DEPLOYED

RESOURCES:
==> v1/PersistentVolumeClaim
NAME                     STATUS  VOLUME                                    CAPACITY  ACCESSMODES  STORAGECLASS  AGE
agile-gibbon-postgresql  Bound   pvc-f4c0d081-47b7-11e7-ae3f-000d3a72314b  8Gi       RWO          7s

==> v1/Service
NAME                     CLUSTER-IP    EXTERNAL-IP  PORT(S)         AGE
agile-gibbon-redis       10.0.160.136  <none>       6379/TCP        6s
agile-gibbon-sentry      10.0.198.236  <pending>    9000:31719/TCP  5s
agile-gibbon-postgresql  10.0.236.82   <none>       5432/TCP        5s

==> v1beta1/Deployment
NAME                        DESIRED  CURRENT  UP-TO-DATE  AVAILABLE  AGE
agile-gibbon-sentry         1        0        0           0          4s
agile-gibbon-sentry-worker  2        0        0           0          4s
agile-gibbon-redis          1        1        1           0          4s
agile-gibbon-postgresql     1        1        1           0          4s
agile-gibbon-sentry-cron    1        0        0           0          4s

==> v1/Secret
NAME                     TYPE    DATA  AGE
agile-gibbon-sentry      Opaque  2     7s
agile-gibbon-postgresql  Opaque  1     7s
agile-gibbon-redis       Opaque  1     7s


NOTES:
1. Get the application URL by running these commands:
     NOTE: It may take a few minutes for the LoadBalancer IP to be available.
           You can watch the status of by running 'kubectl get svc -w agile-gibbon-sentry'
  export SERVICE_IP=$(kubectl get svc --namespace default agile-gibbon-sentry -o jsonpath='{.status.loadBalancer.ingress[0].ip}')
  echo http://$SERVICE_IP:9000
Contributor

lachie83 commented Jun 2, 2017

I got this chart to install with the following changes

~/sandbox/kubernetes/charts/incubator/sentry on pr/1226 [!]
$ git d
 incubator/sentry/requirements.lock                 |  6 ++++--
 incubator/sentry/templates/cron-deployment.yaml    |  2 +-
 incubator/sentry/templates/workers-deployment.yaml |  2 +-
 incubator/sentry/values.yaml                       | 20 ++++++++++----------
 4 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/incubator/sentry/requirements.lock b/incubator/sentry/requirements.lock
index 581a112..5679370 100644
--- a/incubator/sentry/requirements.lock
+++ b/incubator/sentry/requirements.lock
@@ -1,15 +1,17 @@
 dependencies:
 - condition: ""
   enabled: false
+  import-values: null
   name: postgresql
   repository: https://kubernetes-charts.storage.googleapis.com/
   tags: null
   version: 0.7.1
 - condition: ""
   enabled: false
+  import-values: null
   name: redis
   repository: https://kubernetes-charts.storage.googleapis.com/
   tags: null
   version: 0.6.0
-digest: sha256:ea6510a357c699082e455250d166978c363f420ee8d589c48492e83b4c376eba
-generated: 2017-06-02T06:18:46.211627938Z
+digest: sha256:dbaa80dbd8326dc559176f3bb5c97723b5a9c6378cd5b01fe3d0787825de9bac
+generated: 2017-06-02T10:11:05.87979944-07:00
diff --git a/incubator/sentry/templates/cron-deployment.yaml b/incubator/sentry/templates/cron-deployment.yaml
index ae212fc..94b9c25 100644
--- a/incubator/sentry/templates/cron-deployment.yaml
+++ b/incubator/sentry/templates/cron-deployment.yaml
@@ -1,7 +1,7 @@
 apiVersion: extensions/v1beta1
 kind: Deployment
 metadata:
-  name: {{ template "fullname" . }}
+  name: {{ template "fullname" . }}-cron
   labels:
     chart: "{{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}"
 spec:
diff --git a/incubator/sentry/templates/workers-deployment.yaml b/incubator/sentry/templates/workers-deployment.yaml
index 374004b..ed1862b 100644
--- a/incubator/sentry/templates/workers-deployment.yaml
+++ b/incubator/sentry/templates/workers-deployment.yaml
@@ -1,7 +1,7 @@
 apiVersion: extensions/v1beta1
 kind: Deployment
 metadata:
-  name: {{ template "fullname" . }}
+  name: {{ template "fullname" . }}-worker
   labels:
     chart: "{{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}"
 spec:
diff --git a/incubator/sentry/values.yaml b/incubator/sentry/values.yaml
index 6006b51..08b929d 100644
--- a/incubator/sentry/values.yaml
+++ b/incubator/sentry/values.yaml
@@ -21,17 +21,17 @@ resources:
     cpu: 100m
     memory: 128Mi

-  ## Enable persistence using Persistent Volume Claims
-  ## ref: http://kubernetes.io/docs/user-guide/persistent-volumes/
+## Enable persistence using Persistent Volume Claims
+## ref: http://kubernetes.io/docs/user-guide/persistent-volumes/
+##
+persistence:
+  enabled: false
+  ## If defined, volume.beta.kubernetes.io/storage-class: <storageClass>
+  ## Default: volume.alpha.kubernetes.io/storage-class: default
   ##
-  persistence:
-    enabled: false
-    ## If defined, volume.beta.kubernetes.io/storage-class: <storageClass>
-    ## Default: volume.alpha.kubernetes.io/storage-class: default
-    ##
-    # storageClass:
-    accessMode: ReadWriteOnce
-    size: 8Gi
+  # storageClass:
+  accessMode: ReadWriteOnce
+  size: 8Gi

 ## Configure ingress resource that allow you to access the
 ## Sentry instalation. Set up the URL
~/sandbox/kubernetes/charts/incubator/sentry on pr/1226 [!]
$ helm install .
NAME:   agile-gibbon
LAST DEPLOYED: Fri Jun  2 10:21:44 2017
NAMESPACE: default
STATUS: DEPLOYED

RESOURCES:
==> v1/PersistentVolumeClaim
NAME                     STATUS  VOLUME                                    CAPACITY  ACCESSMODES  STORAGECLASS  AGE
agile-gibbon-postgresql  Bound   pvc-f4c0d081-47b7-11e7-ae3f-000d3a72314b  8Gi       RWO          7s

==> v1/Service
NAME                     CLUSTER-IP    EXTERNAL-IP  PORT(S)         AGE
agile-gibbon-redis       10.0.160.136  <none>       6379/TCP        6s
agile-gibbon-sentry      10.0.198.236  <pending>    9000:31719/TCP  5s
agile-gibbon-postgresql  10.0.236.82   <none>       5432/TCP        5s

==> v1beta1/Deployment
NAME                        DESIRED  CURRENT  UP-TO-DATE  AVAILABLE  AGE
agile-gibbon-sentry         1        0        0           0          4s
agile-gibbon-sentry-worker  2        0        0           0          4s
agile-gibbon-redis          1        1        1           0          4s
agile-gibbon-postgresql     1        1        1           0          4s
agile-gibbon-sentry-cron    1        0        0           0          4s

==> v1/Secret
NAME                     TYPE    DATA  AGE
agile-gibbon-sentry      Opaque  2     7s
agile-gibbon-postgresql  Opaque  1     7s
agile-gibbon-redis       Opaque  1     7s


NOTES:
1. Get the application URL by running these commands:
     NOTE: It may take a few minutes for the LoadBalancer IP to be available.
           You can watch the status of by running 'kubectl get svc -w agile-gibbon-sentry'
  export SERVICE_IP=$(kubectl get svc --namespace default agile-gibbon-sentry -o jsonpath='{.status.loadBalancer.ingress[0].ip}')
  echo http://$SERVICE_IP:9000
@rothgar

This comment has been minimized.

Show comment
Hide comment
@rothgar

rothgar Jun 5, 2017

Contributor

I have a job that needs to run once during installation. Is there an example I can look at for this? For a fresh install I need to initialize the database with sentry upgrade

Contributor

rothgar commented Jun 5, 2017

I have a job that needs to run once during installation. Is there an example I can look at for this? For a fresh install I need to initialize the database with sentry upgrade

@rothgar

This comment has been minimized.

Show comment
Hide comment
@rothgar

rothgar Jun 7, 2017

Contributor

I found the hooks docs (examples also in spinnaker). Added db init and user creation.

Still need

  • smtp settings
  • persistant storage
  • plugins
Contributor

rothgar commented Jun 7, 2017

I found the hooks docs (examples also in spinnaker). Added db init and user creation.

Still need

  • smtp settings
  • persistant storage
  • plugins
@rothgar

This comment has been minimized.

Show comment
Hide comment
@rothgar

rothgar Jun 7, 2017

Contributor

Just for reference, I'm also running into this issue helm/helm#1769 with the jobs

Contributor

rothgar commented Jun 7, 2017

Just for reference, I'm also running into this issue helm/helm#1769 with the jobs

@rothgar

This comment has been minimized.

Show comment
Hide comment
@rothgar

rothgar Jun 8, 2017

Contributor

@lachie83 have an example of disabling sub charts if they're not needed (eg postgres)? I found this https://docs.helm.sh/chart-best-practices/#conditions-and-tags but not sure how to implement that for a subchart. I searched the repo (not very well) and didn't see an example.

Contributor

rothgar commented Jun 8, 2017

@lachie83 have an example of disabling sub charts if they're not needed (eg postgres)? I found this https://docs.helm.sh/chart-best-practices/#conditions-and-tags but not sure how to implement that for a subchart. I searched the repo (not very well) and didn't see an example.

@lachie83

This comment has been minimized.

Show comment
Hide comment
@lachie83

lachie83 Jun 8, 2017

Contributor

Unfortunately you cannot use the conditions on local subcharts only with dependencies as you mentioned above. One way I've see before is to set a global flag in the top chart values.yaml and conditionalize creation of all resources in the subchart on that flag. eg

{{- if .Values.global.postgres.enabled }}
{{ end }}

Does that help?

Contributor

lachie83 commented Jun 8, 2017

Unfortunately you cannot use the conditions on local subcharts only with dependencies as you mentioned above. One way I've see before is to set a global flag in the top chart values.yaml and conditionalize creation of all resources in the subchart on that flag. eg

{{- if .Values.global.postgres.enabled }}
{{ end }}

Does that help?

@rothgar rothgar changed the title from [WIP] Sentry chart to Sentry chart Jun 8, 2017

@rothgar

This comment has been minimized.

Show comment
Hide comment
@rothgar

rothgar Jun 8, 2017

Contributor

I think this is at a minimal viable chart.

Can someone test in a different environment for me?

Contributor

rothgar commented Jun 8, 2017

I think this is at a minimal viable chart.

Can someone test in a different environment for me?

@lachie83

This comment has been minimized.

Show comment
Hide comment
@lachie83

lachie83 Jun 8, 2017

Contributor

All pods come up and running and the job exits success following an install. How else would you like me to test? Is there something functional I can do?

bailing-possum-postgresql-2744245312-nwv54       1/1       Running   0          6m
bailing-possum-redis-46185774-1w33d              1/1       Running   0          6m
bailing-possum-sentry-884421309-5k861            1/1       Running   0          6m
bailing-possum-sentry-cron-3640742245-4s8pb      1/1       Running   1          6m
bailing-possum-sentry-worker-1644057744-8hwzq    1/1       Running   1          6m
bailing-possum-sentry-worker-1644057744-lfqvd    1/1       Running   1          6m
kubectl get jobs
NAME                     DESIRED   SUCCESSFUL   AGE
bailing-possum-db-init   1         1            7m
Contributor

lachie83 commented Jun 8, 2017

All pods come up and running and the job exits success following an install. How else would you like me to test? Is there something functional I can do?

bailing-possum-postgresql-2744245312-nwv54       1/1       Running   0          6m
bailing-possum-redis-46185774-1w33d              1/1       Running   0          6m
bailing-possum-sentry-884421309-5k861            1/1       Running   0          6m
bailing-possum-sentry-cron-3640742245-4s8pb      1/1       Running   1          6m
bailing-possum-sentry-worker-1644057744-8hwzq    1/1       Running   1          6m
bailing-possum-sentry-worker-1644057744-lfqvd    1/1       Running   1          6m
kubectl get jobs
NAME                     DESIRED   SUCCESSFUL   AGE
bailing-possum-db-init   1         1            7m
@rothgar

This comment has been minimized.

Show comment
Hide comment
@rothgar

rothgar Jun 8, 2017

Contributor

@lachie83 I think I'm mostly curious about what are requirements for the chart to be merged into the main repo? Are there typical tests that are performed? Are charts checked against k8s clusters in GKE, AWS, Azure?

I'm working on the changes @gianrubio suggested but after that I'm not sure how much else needs to be done before it can be merged.

Contributor

rothgar commented Jun 8, 2017

@lachie83 I think I'm mostly curious about what are requirements for the chart to be merged into the main repo? Are there typical tests that are performed? Are charts checked against k8s clusters in GKE, AWS, Azure?

I'm working on the changes @gianrubio suggested but after that I'm not sure how much else needs to be done before it can be merged.

@lachie83

This comment has been minimized.

Show comment
Hide comment
@lachie83

lachie83 Jun 8, 2017

Contributor

@rothgar here's the technical checklist on getting it merged

https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements

The current charts are tested against a 1.6 cluster running on GKE only. They only test lint and installation through to a running pod. You could also add helm tests which we hope to use eventually. See https://github.com/kubernetes/charts/blob/master/stable/consul/templates/test-config.yaml for example

Contributor

lachie83 commented Jun 8, 2017

@rothgar here's the technical checklist on getting it merged

https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements

The current charts are tested against a 1.6 cluster running on GKE only. They only test lint and installation through to a running pod. You could also add helm tests which we hope to use eventually. See https://github.com/kubernetes/charts/blob/master/stable/consul/templates/test-config.yaml for example

Show outdated Hide outdated incubator/sentry/Chart.yaml Outdated
@lachie83

This comment has been minimized.

Show comment
Hide comment
@lachie83

lachie83 Jun 8, 2017

Contributor

Other than a readme and sorting out those other comments you should be GTG AFAICT

Contributor

lachie83 commented Jun 8, 2017

Other than a readme and sorting out those other comments you should be GTG AFAICT

@rothgar

This comment has been minimized.

Show comment
Hide comment
@rothgar

rothgar Jun 8, 2017

Contributor

Thanks for the info. I have a few more changes and need to switch the default password to be randomly generated and print it out in the NOTES. I'll try to get to that today and should be able to finish up the chart.

Contributor

rothgar commented Jun 8, 2017

Thanks for the info. I have a few more changes and need to switch the default password to be randomly generated and print it out in the NOTES. I'll try to get to that today and should be able to finish up the chart.

@lachie83

This comment has been minimized.

Show comment
Hide comment
@lachie83
Contributor

lachie83 commented Jun 8, 2017

@rothgar

This comment has been minimized.

Show comment
Hide comment
@rothgar

rothgar Jun 9, 2017

Contributor

Alright, this deployed for me on minikube and GKE.

I'd like to add options to not deploy postgres and redis but I'm still not exactly sure how to do that. Otherwise this deploys fine for me.

Contributor

rothgar commented Jun 9, 2017

Alright, this deployed for me on minikube and GKE.

I'd like to add options to not deploy postgres and redis but I'm still not exactly sure how to do that. Otherwise this deploys fine for me.

@rothgar

This comment has been minimized.

Show comment
Hide comment
@rothgar

rothgar Jun 13, 2017

Contributor

Can someone go ahead and test this chart? I think it's ready to be merged.

Contributor

rothgar commented Jun 13, 2017

Can someone go ahead and test this chart? I think it's ready to be merged.

@seanknox

This comment has been minimized.

Show comment
Hide comment
@seanknox

seanknox Jun 14, 2017

Contributor

@k8s-bot ok to test

Contributor

seanknox commented Jun 14, 2017

@k8s-bot ok to test

@seanknox

Great first chart! Just kicked off CI. Assuming it passes, last things to fix are 1) update name in Chart.yaml per Lachie and 2) use the same labels for all resources

Show outdated Hide outdated incubator/sentry/templates/hooks/user-create.job.yaml Outdated
@seanknox

This comment has been minimized.

Show comment
Hide comment
@seanknox

seanknox Jun 15, 2017

Contributor

@rothgar Just noticed this chart is under incubator/, which is for charts that use alpha Kubernetes resources. We should do a better job of making that clear. In the meantime, you should move to stable/, though not blocking for this PR.

Contributor

seanknox commented Jun 15, 2017

@rothgar Just noticed this chart is under incubator/, which is for charts that use alpha Kubernetes resources. We should do a better job of making that clear. In the meantime, you should move to stable/, though not blocking for this PR.

@rothgar

This comment has been minimized.

Show comment
Hide comment
@rothgar

rothgar Jun 15, 2017

Contributor

Thanks for the clarification. I never did know what the difference was.

Contributor

rothgar commented Jun 15, 2017

Thanks for the clarification. I never did know what the difference was.

Show outdated Hide outdated stable/sentry/Chart.yaml Outdated
@seanknox

This comment has been minimized.

Show comment
Hide comment
@seanknox

seanknox Jun 15, 2017

Contributor

One last change and we should be gtg

Contributor

seanknox commented Jun 15, 2017

One last change and we should be gtg

@seanknox

This comment has been minimized.

Show comment
Hide comment
@seanknox

seanknox Jun 15, 2017

Contributor

@k8s-bot ok to test

Contributor

seanknox commented Jun 15, 2017

@k8s-bot ok to test

@seanknox seanknox merged commit cb00608 into helm:master Jun 15, 2017

2 checks passed

cla/linuxfoundation rothgar authorized
Details
pull-charts-e2e Jenkins job succeeded.
Details
@seanknox

This comment has been minimized.

Show comment
Hide comment
@seanknox

seanknox Jun 15, 2017

Contributor

Thanks @rothgar for your first chart!

Contributor

seanknox commented Jun 15, 2017

Thanks @rothgar for your first chart!

@nhoughto

This comment has been minimized.

Show comment
Hide comment
@nhoughto

nhoughto Jun 26, 2017

I can't get this to run if i specify a release name in helm, only

helm install --wait stable/sentry

works, if i specify --name blah then i get a timeout and failure. Looks like the user-create job fails connecting to the database. Is it expected that a release name can't be specified?

nhoughto commented Jun 26, 2017

I can't get this to run if i specify a release name in helm, only

helm install --wait stable/sentry

works, if i specify --name blah then i get a timeout and failure. Looks like the user-create job fails connecting to the database. Is it expected that a release name can't be specified?

flah00 added a commit to Adaptly/charts that referenced this pull request Jun 28, 2017

Sentry chart (helm#1226)
* initial sentry

* missing valueFrom

* added cron and worker deployments

* Added some metadata

* Initial ingress support

* add initial smtp support and volume persistence

* Fixed deployment names (duh)

* Fix ENV and remove liveliness/rediness

* Hard code sentry db and user name until I can figure it out

* Fixed postgresql values

* Add database initialization job

* Add user creation hook

* Add user configuration to values

* Added smtp support, various other options/fixes

* Add resource limits, health check, and random password

* Fix login url and command to show generated password

* Add README and set sane default values

* Clarify using the --wait flag in README

* Consistent labels and component names

* Move sentry to stable folder

* Updated name to github username

c-knowles added a commit to c-knowles/helm-charts that referenced this pull request Jun 29, 2017

Sentry chart (helm#1226)
* initial sentry

* missing valueFrom

* added cron and worker deployments

* Added some metadata

* Initial ingress support

* add initial smtp support and volume persistence

* Fixed deployment names (duh)

* Fix ENV and remove liveliness/rediness

* Hard code sentry db and user name until I can figure it out

* Fixed postgresql values

* Add database initialization job

* Add user creation hook

* Add user configuration to values

* Added smtp support, various other options/fixes

* Add resource limits, health check, and random password

* Fix login url and command to show generated password

* Add README and set sane default values

* Clarify using the --wait flag in README

* Consistent labels and component names

* Move sentry to stable folder

* Updated name to github username

yanns pushed a commit to yanns/charts that referenced this pull request Jul 28, 2017

Sentry chart (helm#1226)
* initial sentry

* missing valueFrom

* added cron and worker deployments

* Added some metadata

* Initial ingress support

* add initial smtp support and volume persistence

* Fixed deployment names (duh)

* Fix ENV and remove liveliness/rediness

* Hard code sentry db and user name until I can figure it out

* Fixed postgresql values

* Add database initialization job

* Add user creation hook

* Add user configuration to values

* Added smtp support, various other options/fixes

* Add resource limits, health check, and random password

* Fix login url and command to show generated password

* Add README and set sane default values

* Clarify using the --wait flag in README

* Consistent labels and component names

* Move sentry to stable folder

* Updated name to github username
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment