Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix efs provisioner mountOptions #12361

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
4 participants
@tsakamiya
Copy link
Contributor

commented Mar 19, 2019

Signed-off-by: Tomoki Sakamiya tsakamiya@gmail.com

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
fix efs provisioner mountOptions
Signed-off-by: Tomoki Sakamiya <tsakamiya@gmail.com>
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

Hi @tsakamiya. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hareku

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2019

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 19, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hareku, tsakamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

@hareku: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 7de7776 into helm:master Mar 19, 2019

6 checks passed

DCO DCO
Details
ci/circleci: lint-charts Your tests passed on CircleCI!
Details
ci/circleci: lint-scripts Your tests passed on CircleCI!
Details
dco-labeler All commits have signoff
pull-charts-e2e Job succeeded.
Details
tide In merge pool.
Details

rmccorm4 added a commit to rmccorm4/charts that referenced this pull request Mar 26, 2019

fix efs provisioner mountOptions (helm#12361)
Signed-off-by: Tomoki Sakamiya <tsakamiya@gmail.com>

crackmac pushed a commit to crackmac/charts that referenced this pull request Mar 29, 2019

fix efs provisioner mountOptions (helm#12361)
Signed-off-by: Tomoki Sakamiya <tsakamiya@gmail.com>

crackmac pushed a commit to crackmac/charts that referenced this pull request Mar 29, 2019

fix efs provisioner mountOptions (helm#12361)
Signed-off-by: Tomoki Sakamiya <tsakamiya@gmail.com>
Signed-off-by: Kevin Duane <duank001@apps.disney.com>

PierluigiLenociAkelius added a commit to PierluigiLenociAkelius/charts that referenced this pull request Apr 25, 2019

fix efs provisioner mountOptions (helm#12361)
Signed-off-by: Tomoki Sakamiya <tsakamiya@gmail.com>
Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@akelius.de>

devnulled added a commit to devnulled/charts that referenced this pull request Apr 25, 2019

fix efs provisioner mountOptions (helm#12361)
Signed-off-by: Tomoki Sakamiya <tsakamiya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.