Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add portus chart #1284
Hi @so0k. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
I understand the commands that are listed here.
@so0k: The following test failed, say
Are you going to keep come up with an update? Also, please used best practices for standard labels. Especially, the
app label should use
name instead of
Note: a vanilla k8s cluster will need ingress controller with TLS...
@unguiculus - I'm confused regarding app label as I try to refer to several other stable charts and I don't see that best practice applied anywhere?
most seem to use
I'll look at changing this if you can clarify how multiple releases of same chart will no cause issues.
@so0k Best practices have not been set in stone from day one. They evolve over time. Latest best practices are reflected in the chart examples (https://github.com/kubernetes/helm/tree/master/docs/examples) and in the experience you get when creating a new chart with