[stable/mongodb] Fix 'storageClass' macros

[alemorcuq]

Signed-off-by: Alejandro Moreno amoreno@bitnami.com

What this PR does / why we need it:

At #16434 we introduced a new macro that allows us to use a global.storageClass parameter to overwrite any other storageClassName used on other parameters.

Despite new PVCs and Statefulsets generated are syntactically correct (PVC manifests generate exactly the same PVC in the K8s cluster), we introduce a backwards incompatibility since Helm includes some "sanity checks" to ensure immutable objects do not change their specs during an upgrade (see the error below):

Error: UPGRADE FAILED: PersistentVolumeClaim "xxxxx" is invalid: spec: Forbidden: is immutable after creation except resources.requests for bound claims

This error is a consequence of the change below introduced in the PR (when no storagleClass is provided):

kind: PersistentVolumeClaim
...
    requests:
      storage: "8Gi"
+   storageClassName: 

Checklist

• DCO signed
• Chart Version bumped
• Title of the PR starts with chart name (e.g. [stable/chart])

[k8s-ci-robot]

Hi @alemorcuq. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[juan131]

Thanks for the fix!
/ok-to-test
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alemorcuq, juan131

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/mongodb/OWNERS [juan131]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment