Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[stable/ambassador] Added sidecarContainers parameter #17579
Signed-off-by: Pieter Vogelaar email@example.com
What this PR does / why we need it:
With this PR a AuthService (https://www.getambassador.io/reference/services/auth-service/) can run as sidecar container in the same pod context as the ambassador pod.
I have a use case where the auth service determines based on the host header
Running the auth service as a sidecar container is the fastest way possible, no network latency etc.
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
Hi @pietervogelaar. Thanks for your PR.
I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
* Added sidecarContainers parameter Signed-off-by: Pieter Vogelaar <firstname.lastname@example.org> * Bumped version from 4.1.0 to 4.2.0 Signed-off-by: Pieter Vogelaar <email@example.com> Signed-off-by: Ali Sattari <firstname.lastname@example.org>