Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/ambassador] Added sidecarContainers parameter #17579

Merged

Conversation

@pietervogelaar
Copy link
Contributor

commented Oct 1, 2019

Signed-off-by: Pieter Vogelaar pieter@pietervogelaar.nl

What this PR does / why we need it:

With this PR a AuthService (https://www.getambassador.io/reference/services/auth-service/) can run as sidecar container in the same pod context as the ambassador pod.

I have a use case where the auth service determines based on the host header footenant-staging.my-ruby-api.example if a tenant belongs to the tenant group early-adopters, early-majority or late-majority. It adds a request header. Based on this, the request will reach the app in the correct kubernetes namespace.

Running the auth service as a sidecar container is the fastest way possible, no network latency etc.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])
Signed-off-by: Pieter Vogelaar <pieter@pietervogelaar.nl>
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2019

Hi @pietervogelaar. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pietervogelaar

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

/assign @Flydiverny

@Flydiverny

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

@pietervogelaar
not much to say here other than needs a chart version bump in chart.yaml 4.1.0 -> 4.2.0

/ok-to-test

Signed-off-by: Pieter Vogelaar <pieter@pietervogelaar.nl>
@Flydiverny

This comment has been minimized.

Copy link
Collaborator

commented Oct 2, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 2, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Flydiverny, pietervogelaar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f5bcdc1 into helm:master Oct 2, 2019
6 checks passed
6 checks passed
DCO DCO
Details
ci/circleci: lint-charts Your tests passed on CircleCI!
Details
ci/circleci: lint-scripts Your tests passed on CircleCI!
Details
dco-labeler All commits have signoff
pull-charts-e2e Job succeeded.
Details
tide In merge pool.
Details
isaaguilar added a commit to isaaguilar/charts that referenced this pull request Oct 3, 2019
* Added sidecarContainers parameter

Signed-off-by: Pieter Vogelaar <pieter@pietervogelaar.nl>

* Bumped version from 4.1.0 to 4.2.0

Signed-off-by: Pieter Vogelaar <pieter@pietervogelaar.nl>
ali-sattari added a commit to ali-sattari/charts that referenced this pull request Oct 7, 2019
* Added sidecarContainers parameter

Signed-off-by: Pieter Vogelaar <pieter@pietervogelaar.nl>

* Bumped version from 4.1.0 to 4.2.0

Signed-off-by: Pieter Vogelaar <pieter@pietervogelaar.nl>
Signed-off-by: Ali Sattari <ali.sattari@gmail.com>
pennycoders pushed a commit to pennycoders/charts that referenced this pull request Oct 11, 2019
* Added sidecarContainers parameter

Signed-off-by: Pieter Vogelaar <pieter@pietervogelaar.nl>

* Bumped version from 4.1.0 to 4.2.0

Signed-off-by: Pieter Vogelaar <pieter@pietervogelaar.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.