Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Add changelog to note that 3.0.0 drops all existing data #18819

Merged
merged 1 commit into from Nov 13, 2019
Merged

Add changelog to note that 3.0.0 drops all existing data #18819

merged 1 commit into from Nov 13, 2019

Conversation

ekeih
Copy link
Contributor

@ekeih ekeih commented Nov 12, 2019

What this PR does / why we need it:

The update to 3.0.0 drops all existing data because the switch from a Deployment to a StatefulSet (#17619, #18479) creates a new volume with a different name. This is a very unpleasant surprise and should at least be mentioned in the changelog.

Checklist

  • DCO signed
  • Chart Version bumped

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 12, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @ekeih. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 12, 2019
Signed-off-by: Max Rosin <git@hackrid.de>
@Aisuko
Copy link
Collaborator

Aisuko commented Nov 13, 2019

/assign

@Aisuko
Copy link
Collaborator

Aisuko commented Nov 13, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 13, 2019
Aisuko
Aisuko approved these changes Nov 13, 2019
Copy link
Collaborator

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Aisuko, ekeih

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@Aisuko
Copy link
Collaborator

Aisuko commented Nov 13, 2019

Thanks.

@k8s-ci-robot k8s-ci-robot merged commit 0908c61 into helm:master Nov 13, 2019
@ekeih ekeih deleted the influxdb-changelog branch November 13, 2019 13:06
JoseAlban pushed a commit to JoseAlban/charts that referenced this pull request Nov 22, 2019
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants