Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Initial release for Jaeger Helm Chart #2078
This is the initial release for the Jaeger Helm Chart.
helm lint: Pass
Hi @dvonthenen. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
I understand the commands that are listed here.
Thanks for the PR. Please check our best practices for standard labels, especially regarding the
I made a few comments. Please apply them throughout the whole chart. I usually only specified them once.
Here's a good example: https://github.com/kubernetes/charts/tree/master/stable/nginx-ingress
You may take this also as reference for grouping values.
@unguiculus Added in resources and nodeSelector for the various components.
Also updated the various files based on the review at: https://github.com/kubernetes/charts/pull/2078/files/eccf2e7f224a3519e128a70242613ba6c0535e8a
The last outstanding item about the Cassandra subchart not using camel case. Looking for guidance on how to proceed.