Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(chart): Add baseline NiFi chart #5772
What this PR does / why we need it: Adds NiFi chart (https://nifi.apache.org/)
Which issue this PR fixes (optional, in
Special notes for your reviewer: Went through a variety of NiFi charts and tried to pick the best elements of each. Right now am using my extended docker NiFi image which adds toolkit, but if better can just simply call the official apache/nifi:1.6.0 image.
I realize this might be a bit of back and forth but wanted to get this started!
P.S. A corresponding Kylo charts also has a P.R. #5773
Just including some platform experts to get their take also:
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sylus
Assign the PR to them by writing
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Hi @sylus. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
I understand the commands that are listed here.
@sylus I get an error when templating your chart. Some parse error occurs. I attached the error log below. I run Helm version helm-v2.9.1-windows-amd64.
On another note, it might be useful to expose the setting for
@sylus Any update on this?
I've tried to run this within this helm docker container, using this image.
my requirements.yaml contains this:
And I changed the zookeeper.enabled to false in Values.yaml
Thanks so much @mattfarina for the review I know your super busy and I truly appreciate you taking the time.
Also thanks @tvince for doing this! Your awesome! I'm not immediately sure but that line is from the state-management.xml file. And I guess it works with my image because I created this folder. Temporarily if you switch to the govcloud extended image does that work?
If so I can adjust the configmaps to make sure they work with just the base image :)
Will take a look at this over the long weekend ^_^