This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[external-dns] Added affinity. #7194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
/assign @scottrigby |
davidkarlsen
suggested changes
Aug 15, 2018
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
| @@ -141,5 +141,7 @@ spec: | |||
| {{- if .Values.tolerations }} | |||
| tolerations: | |||
| {{ toYaml .Values.tolerations | indent 8 }} | |||
| affinity: | |||
| {{ toYaml .Values.affinity | indent 8 }} | |||
There was a problem hiding this comment.
should maybe be outside the tolerations conditional?
|
Updated |
|
/lgtm |
mattfarina
added
the
Contribution Allowed
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidkarlsen, lachie83, michalschott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ishabalin
pushed a commit
to NinthDecimal/charts
that referenced
this pull request
Sep 3, 2018
Signed-off-by: ishabalin <ishabalin@ninthdecimal.com>
marekaf
pushed a commit
to marekaf/charts
that referenced
this pull request
Sep 4, 2018
Signed-off-by: Marek Bartik <mab@revolgy.com> Signed-off-by: Marek Bartik <bartimar6@gmail.com>
aba182
pushed a commit
to aba182/charts
that referenced
this pull request
Sep 7, 2018
Signed-off-by: aba182 <ajwilhel@gmail.com>
aba182
pushed a commit
to aba182/charts
that referenced
this pull request
Sep 7, 2018
Signed-off-by: aba182 <ajwilhel@gmail.com>
jicowan
pushed a commit
to jicowan/charts
that referenced
this pull request
Oct 2, 2018
Signed-off-by: jenkin-x <jicowan@hotmail.com>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
Signed-off-by: Jakob Niggel <info@jakobniggel.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It adds affinity to external-dns pod.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #N/A
Special notes for your reviewer:
None