[stable/chaoskube] Support K8S older then 1.9 #7195
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
cncf-cla: no
k8s-ci-robot
added
the
needs-ok-to-test
|
/assign @linki |
|
Could you sign the CLA @shaikatz? |
|
/ok-to-test |
k8s-ci-robot
added
cncf-cla: yes
|
@linki I had some issues signing the CLA, it's ready now :) |
| @@ -1,4 +1,8 @@ | |||
| {{- if semverCompare "^1.9-0" .Capabilities.KubeVersion.GitVersion }} | |||
There was a problem hiding this comment.
Is it better to use capabilities in https://github.com/helm/helm/blob/master/docs/chart_template_guide/builtin_objects.md: "Capabilities.APIVersions.Has $version indicates whether a version (batch/v1) is enabled on the cluster."
|
@davidkarlsen Cool method, wasn't familiar with that. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: linki, shaikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
* Support K8S older then 1.9 * Use APIVersion * Go the other direction Signed-off-by: Marek Bartik <mab@revolgy.com> Signed-off-by: Marek Bartik <bartimar6@gmail.com>
* Support K8S older then 1.9 * Use APIVersion * Go the other direction Signed-off-by: aba182 <ajwilhel@gmail.com>
* Support K8S older then 1.9 * Use APIVersion * Go the other direction Signed-off-by: aba182 <ajwilhel@gmail.com>
* Support K8S older then 1.9 * Use APIVersion * Go the other direction Signed-off-by: Jakob Niggel <info@jakobniggel.de>
Add support for API versions for older k8s in the deployment file.