Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(octopus): Add baseline Octopus chart #7769

Closed
wants to merge 1 commit into from

Conversation

@sylus
Copy link

commented Sep 17, 2018

What this PR does / why we need it: Adds baseline Octopus Helm chart

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes # N/A

Special notes for your reviewer: There is still one tasks that needs to be done but I have been successfully running this with AzureAD integration and MSSQL Server on Linux.

  • Add optional MSSQL for Linux
  • Run through Linter
  • Figure out issue with Octopus container
  • Leverage official docker containers
  • Hard coded LB config under sqlDbConnectionString as Linux mssql svc not added to Win host
  • Add tentacle container image (waiting on upstream 1709, 1803)

Pinging Octopus maintainer(s) @PaulStovell @zentron

@k8s-ci-robot k8s-ci-robot requested review from foxish and lachie83 Sep 17, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2018

Hi @sylus. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sylus sylus force-pushed the govcloud:chart-octopus branch Sep 18, 2018

@sylus sylus force-pushed the govcloud:chart-octopus branch Sep 18, 2018

@sylus sylus force-pushed the govcloud:chart-octopus branch Sep 19, 2018

@sylus sylus force-pushed the govcloud:chart-octopus branch Sep 24, 2018

@sylus sylus force-pushed the govcloud:chart-octopus branch Sep 24, 2018

@sylus sylus force-pushed the govcloud:chart-octopus branch Sep 24, 2018

@sylus sylus force-pushed the govcloud:chart-octopus branch 2 times, most recently to c06aae1 Oct 19, 2018

@helm-bot helm-bot added the size/XXL label Oct 28, 2018

@stale

This comment has been minimized.

Copy link

commented Nov 28, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Nov 28, 2018

@sylus

This comment has been minimized.

Copy link
Author

commented Nov 28, 2018

/remove-lifecycle stale

@stale stale bot removed the lifecycle/stale label Nov 28, 2018

@stale

This comment has been minimized.

Copy link

commented Dec 28, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Dec 28, 2018

@sylus

This comment has been minimized.

Copy link
Author

commented Dec 28, 2018

/remove-lifecycle stale

@stale stale bot removed the lifecycle/stale label Dec 28, 2018

@stale

This comment has been minimized.

Copy link

commented Jan 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@sylus

This comment has been minimized.

Copy link
Author

commented Jan 27, 2019

Hey @zentron @christianacca you know if anyone in Octopus has looked at this yet? Has been running solid for past 2-3 months and numerous upgrades.

@zentron

This comment has been minimized.

Copy link

commented Jan 30, 2019

What were you looking for from our side @sylus ?

@zentron

This comment has been minimized.

Copy link

commented Jan 30, 2019

We may end up needing to publish an officially supported helm chart in the future as the available environment variables may change in the future

@christianacca

This comment has been minimized.

Copy link

commented Jan 31, 2019

Hi @sylus, I'm only working with docker swarm (at the moment) so can't comment

@sylus

This comment has been minimized.

Copy link
Author

commented Jan 31, 2019

Hey @zentron was just looking for feedback I'll keep improving the chart but is working great. Have updated about 10x without issue. Really liking having a hybrid cluster with both windows + linux (mssql).

Whenever you guys are ready to take it over please let me know :D will be happy to help in any way I can.

@zentron

This comment has been minimized.

Copy link

commented Jan 31, 2019

Looks good from what I can tell @sylus . Will try and keep you posted when we make changes to the octopus image.

@sylus sylus force-pushed the govcloud:chart-octopus branch from 4fc902c to fc2ead0 Jan 31, 2019

@helm-bot helm-bot added size/XXL and removed size/XXL labels Jan 31, 2019

feat(octopus): Minor updates to chart
Signed-off-by: William Hearn <sylus1984@gmail.com>

@sylus sylus force-pushed the govcloud:chart-octopus branch from fc2ead0 to c547f43 Feb 1, 2019

@helm-bot helm-bot added size/XXL and removed size/XXL labels Feb 1, 2019

@stale

This comment has been minimized.

Copy link

commented Mar 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Mar 3, 2019

@sylus

This comment has been minimized.

Copy link
Author

commented Mar 4, 2019

/remove-lifecycle stale

@stale stale bot removed the lifecycle/stale label Mar 4, 2019

@stale

This comment has been minimized.

Copy link

commented Apr 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Apr 3, 2019

@sylus

This comment has been minimized.

Copy link
Author

commented Apr 9, 2019

/remove-lifecycle stale

@stale stale bot removed the lifecycle/stale label Apr 9, 2019

@stale

This comment has been minimized.

Copy link

commented May 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label May 9, 2019

@sylus

This comment has been minimized.

Copy link
Author

commented May 13, 2019

/remove-lifecycle stale

@stale stale bot removed the lifecycle/stale label May 13, 2019

@maorfr

This comment has been minimized.

Copy link
Member

commented May 16, 2019

hey @sylus

Have you considered hosting this chart and adding it to helm hub?
https://github.com/helm/hub/blob/master/Repositories.md

(this is your 2nd chart i am seeing, may be best for you)

@stale

This comment has been minimized.

Copy link

commented Jun 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Jun 15, 2019

@stale

This comment has been minimized.

Copy link

commented Jun 29, 2019

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Jun 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.