Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/rabbitmq] fix typo #8700

Merged
merged 1 commit into from Oct 25, 2018
Merged

[stable/rabbitmq] fix typo #8700

merged 1 commit into from Oct 25, 2018

Conversation

@mgrachev
Copy link
Contributor

@mgrachev mgrachev commented Oct 24, 2018

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
@desaintmartin
Copy link
Collaborator

@desaintmartin desaintmartin commented Oct 24, 2018

Thanks! Previous PR bumped version to the same as your, could you rebase and bump again version?

@rimusz
Copy link
Contributor

@rimusz rimusz commented Oct 25, 2018

/lgtm

@rimusz
Copy link
Contributor

@rimusz rimusz commented Oct 25, 2018

/ok-to-test

@rimusz
Copy link
Contributor

@rimusz rimusz commented Oct 25, 2018

/assign @tompizmor

@rimusz
Copy link
Contributor

@rimusz rimusz commented Oct 25, 2018

please bump chart version to 3.5.3

Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 25, 2018
@helm-bot helm-bot added size/XS and removed size/XS labels Oct 25, 2018
@mgrachev
Copy link
Contributor Author

@mgrachev mgrachev commented Oct 25, 2018

@rimusz Done.

@rimusz
Copy link
Contributor

@rimusz rimusz commented Oct 25, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 25, 2018
@rimusz
Copy link
Contributor

@rimusz rimusz commented Oct 25, 2018

/approve

@juan131
Copy link
Collaborator

@juan131 juan131 commented Oct 25, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Oct 25, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juan131, mgrachev, rimusz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e46c588 into helm:master Oct 25, 2018
6 checks passed
6 checks passed
DCO DCO
Details
ci/circleci: lint-charts Your tests passed on CircleCI!
Details
ci/circleci: lint-scripts Your tests passed on CircleCI!
Details
dco-labeler All commits have signoff
pull-charts-e2e Job succeeded.
Details
tide In merge pool.
Details
@mgrachev mgrachev deleted the mgrachev:fix-typo/rabbitmq branch Oct 25, 2018
@mgrachev mgrachev mentioned this pull request Oct 30, 2018
kenichi-shibata added a commit to kenichi-shibata/charts that referenced this pull request Oct 30, 2018
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
Jnig added a commit to Jnig/charts that referenced this pull request Nov 13, 2018
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
Signed-off-by: Jakob Niggel <info@jakobniggel.de>
wgiddens added a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants