Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/keycloak] fix typo #8703

Merged
merged 2 commits into from Nov 17, 2018
Merged

[stable/keycloak] fix typo #8703

merged 2 commits into from Nov 17, 2018

Conversation

@mgrachev
Copy link
Contributor

@mgrachev mgrachev commented Oct 24, 2018

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
@davidkarlsen
Copy link
Member

@davidkarlsen davidkarlsen commented Oct 24, 2018

/ok-to-test
/assign

@rimusz
Copy link
Contributor

@rimusz rimusz commented Oct 25, 2018

/lgtm

@rimusz
Copy link
Contributor

@rimusz rimusz commented Oct 25, 2018

/assign @davidkarlsen

@davidkarlsen
Copy link
Member

@davidkarlsen davidkarlsen commented Oct 29, 2018

/retest

1 similar comment
@mgrachev
Copy link
Contributor Author

@mgrachev mgrachev commented Oct 30, 2018

/retest

@mgrachev mgrachev mentioned this pull request Oct 30, 2018
@unguiculus
Copy link
Member

@unguiculus unguiculus commented Nov 9, 2018

/retest

@unguiculus
Copy link
Member

@unguiculus unguiculus commented Nov 9, 2018

/lgtm

@helm-bot helm-bot removed the size/S label Nov 16, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 16, 2018
@helm-bot helm-bot added the size/S label Nov 16, 2018
@davidkarlsen
Copy link
Member

@davidkarlsen davidkarlsen commented Nov 17, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 17, 2018
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Nov 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, mgrachev, rimusz, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a977df6 into helm:master Nov 17, 2018
6 checks passed
6 checks passed
DCO DCO
Details
ci/circleci: lint-charts Your tests passed on CircleCI!
Details
ci/circleci: lint-scripts Your tests passed on CircleCI!
Details
dco-labeler All commits have signoff
pull-charts-e2e Job succeeded.
Details
tide In merge pool.
Details
@mgrachev mgrachev deleted the mgrachev:fix-typo/keycloak branch Nov 17, 2018
mcanevet added a commit to mcanevet/charts that referenced this pull request Nov 23, 2018
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
davidkarlsen added a commit to davidkarlsen/charts that referenced this pull request Dec 2, 2018
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
wgiddens added a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
Signed-off-by: Mikhail Grachev <work@mgrachev.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants