New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and promote spring-cloud-data-flow to stable #8757

Merged
merged 4 commits into from Nov 9, 2018

Conversation

@chrisjs
Contributor

chrisjs commented Oct 25, 2018

What this PR does / why we need it:

Deprecates incubator/spring-cloud-data-flow and promotes to stable
Updates to new SCDF version 1.7.0 and deps in stable chart

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

chrisjs added some commits Oct 25, 2018

[incubator/spring-cloud-data-flow] Deprecate incubator/spring-cloud-d…
…ata-flow for promotion to stable

Signed-off-by: Chris Schaefer <cschaefer@pivotal.io>
[stable/spring-cloud-data-flow] Promote to stable and update to new S…
…CDF version 1.7.0

- promote chart to stable
- update app version to 1.7.0
- update chart version to 0.3.0
- update skipper version to 1.1.0
- enable task scheduling & update corresponding RBAC rules

Signed-off-by: Chris Schaefer <cschaefer@pivotal.io>
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 25, 2018

Hi @chrisjs. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrisjs

This comment has been minimized.

Contributor

chrisjs commented Oct 25, 2018

/assign @unguiculus

@chrisjs chrisjs referenced this pull request Oct 25, 2018

Closed

Create Helm chart for 1.7 #324

3 of 4 tasks complete
@chrisjs

This comment has been minimized.

Contributor

chrisjs commented Oct 31, 2018

/assign @sameersbn

Updates from PR review
Signed-off-by: Chris Schaefer <cschaefer@pivotal.io>

@chrisjs chrisjs force-pushed the chrisjs:scdf-version-170-promote branch to 9245834 Nov 2, 2018

Add release label to matchLabels
Signed-off-by: Chris Schaefer <cschaefer@pivotal.io>

@chrisjs chrisjs force-pushed the chrisjs:scdf-version-170-promote branch to ff113fe Nov 5, 2018

@chrisjs

This comment has been minimized.

Contributor

chrisjs commented Nov 7, 2018

@unguiculus anything else needed to get this merged? thanks!

@unguiculus

This comment has been minimized.

Member

unguiculus commented Nov 9, 2018

/ok-to-test

@unguiculus

This comment has been minimized.

Member

unguiculus commented Nov 9, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 9, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Nov 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisjs, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2d9828b into helm:master Nov 9, 2018

5 checks passed

ci/circleci: lint-charts Your tests passed on CircleCI!
Details
ci/circleci: lint-scripts Your tests passed on CircleCI!
Details
dco-labeler All commits have signoff
pull-charts-e2e Job succeeded.
Details
tide In merge pool.
Details

mcanevet added a commit to mcanevet/charts that referenced this pull request Nov 23, 2018

Deprecate and promote spring-cloud-data-flow to stable (helm#8757)
* [incubator/spring-cloud-data-flow] Deprecate incubator/spring-cloud-data-flow for promotion to stable

Signed-off-by: Chris Schaefer <cschaefer@pivotal.io>

* [stable/spring-cloud-data-flow] Promote to stable and update to new SCDF version 1.7.0

- promote chart to stable
- update app version to 1.7.0
- update chart version to 0.3.0
- update skipper version to 1.1.0
- enable task scheduling & update corresponding RBAC rules

Signed-off-by: Chris Schaefer <cschaefer@pivotal.io>

* Updates from PR review

Signed-off-by: Chris Schaefer <cschaefer@pivotal.io>

* Add release label to matchLabels

Signed-off-by: Chris Schaefer <cschaefer@pivotal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment