Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Improve Hazelast Chart to support Scaling Up/Down #9150

Merged
merged 2 commits into from Nov 29, 2018
Merged

Improve Hazelast Chart to support Scaling Up/Down #9150

merged 2 commits into from Nov 29, 2018

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Nov 9, 2018

What this PR does / why we need it:

  • Update Hazelcast to 3.11
  • Change Docker image to hazelcast/hazelcast (hazelcast/hazelcast-kubernetes is no longer supported)
  • Add Graceful Shutdown feature (used in scaling down and rolling upgrade)
  • Add resolve-not-ready-addresses property to check also not ready Hazelcast PODs
  • Increase default parameters for livenessProbe and readinessProbe (helps in stability in case of rolling upgrade and huge amount of data)
  • Simplify hazelcast.xml configuration

Which issue this PR fixes

None.

Special notes for your reviewer:

None.

Checklist

  • [ x ] DCO signed
  • [ x ] Chart Version bumped
  • [ x ] Variables are documented in the README.md

@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 9, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @leszko. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 9, 2018
@leszko
Copy link
Contributor Author

leszko commented Nov 9, 2018

/assign @paulczar

Improve Hazelcast Chart to support Scaling
4377398 
Signed-off-by: Rafal Leszko <rafal@hazelcast.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2018
davidkarlsen
davidkarlsen suggested changes Nov 10, 2018
View reviewed changes
stable/hazelcast/Chart.yaml Outdated Show resolved Hide resolved
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Nov 13, 2018
@leszko
Copy link
Contributor Author

leszko commented Nov 13, 2018

@davidkarlsen Thanks for the review. I applied the change suggested by you. PTAL.

@davidkarlsen
Update stable/hazelcast/Chart.yaml
bddc9e4 
Co-Authored-By: leszko <rafal@hazelcast.com>
Signed-off-by: Rafal Leszko <rafal@hazelcast.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2018
@leszko
Copy link
Contributor Author

leszko commented Nov 15, 2018

@davidkarlsen , could you please have a look?

@cpanato
Copy link
Member

cpanato commented Nov 15, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 15, 2018
@cpanato
Copy link
Member

cpanato commented Nov 15, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2018
@leszko
Copy link
Contributor Author

leszko commented Nov 15, 2018

/approve

@leszko
Copy link
Contributor Author

leszko commented Nov 16, 2018

Do you think this PR is ready to merge?

@leszko
Copy link
Contributor Author

leszko commented Nov 21, 2018

@davidkarlsen , do you think it's ready to merge? It's already 12 days and it's just a small change to our Helm Chart.

@cpanato
Copy link
Member

cpanato commented Nov 22, 2018

ping @davidkarlsen

@leszko
Copy link
Contributor Author

leszko commented Nov 23, 2018

Any news on that? Could we finally get it merged? It's just a small change!

@leszko
Copy link
Contributor Author

leszko commented Nov 27, 2018

Guys, it's already 18 days! Could you get it merged?

@leszko
Copy link
Contributor Author

leszko commented Nov 28, 2018

Guys, again, can we get it merged?

@davidkarlsen @foxish @lachie83 @paulczar @cpanato

@davidkarlsen
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, davidkarlsen, leszko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2018
@k8s-ci-robot k8s-ci-robot merged commit a25c621 into helm:master Nov 29, 2018
yuchaoran2011 pushed a commit to yuchaoran2011/charts that referenced this pull request Nov 30, 2018
@yuchaoran2011
Improve Hazelast Chart to support Scaling Up/Down (helm#9150)
f280330 
* Improve Hazelcast Chart to support Scaling

Signed-off-by: Rafal Leszko <rafal@hazelcast.com>

* Update stable/hazelcast/Chart.yaml

Co-Authored-By: leszko <rafal@hazelcast.com>
Signed-off-by: Rafal Leszko <rafal@hazelcast.com>
davidkarlsen pushed a commit to davidkarlsen/charts that referenced this pull request Dec 2, 2018
@davidkarlsen
Improve Hazelast Chart to support Scaling Up/Down (helm#9150)
07cecb6 
* Improve Hazelcast Chart to support Scaling

Signed-off-by: Rafal Leszko <rafal@hazelcast.com>

* Update stable/hazelcast/Chart.yaml

Co-Authored-By: leszko <rafal@hazelcast.com>
Signed-off-by: Rafal Leszko <rafal@hazelcast.com>
yuchaoran2011 pushed a commit to yuchaoran2011/charts that referenced this pull request Dec 11, 2018
@yuchaoran2011
Improve Hazelast Chart to support Scaling Up/Down (helm#9150)
0532989 
* Improve Hazelcast Chart to support Scaling

Signed-off-by: Rafal Leszko <rafal@hazelcast.com>

* Update stable/hazelcast/Chart.yaml

Co-Authored-By: leszko <rafal@hazelcast.com>
Signed-off-by: Rafal Leszko <rafal@hazelcast.com>
Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com>
coreypobrien pushed a commit to FairwindsOps/helm-charts that referenced this pull request Dec 31, 2018
@coreypobrien
Improve Hazelast Chart to support Scaling Up/Down (helm#9150)
4185bd9 
* Improve Hazelcast Chart to support Scaling

Signed-off-by: Rafal Leszko <rafal@hazelcast.com>

* Update stable/hazelcast/Chart.yaml

Co-Authored-By: leszko <rafal@hazelcast.com>
Signed-off-by: Rafal Leszko <rafal@hazelcast.com>
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@wgiddens
Improve Hazelast Chart to support Scaling Up/Down (helm#9150)
125f8c0 
* Improve Hazelcast Chart to support Scaling

Signed-off-by: Rafal Leszko <rafal@hazelcast.com>

* Update stable/hazelcast/Chart.yaml

Co-Authored-By: leszko <rafal@hazelcast.com>
Signed-off-by: Rafal Leszko <rafal@hazelcast.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidkarlsen davidkarlsen davidkarlsen approved these changes

@foxish foxish Awaiting requested review from foxish

@lachie83 lachie83 Awaiting requested review from lachie83

Assignees

@paulczar paulczar

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@leszko @k8s-ci-robot @cpanato @davidkarlsen @paulczar @helm-bot