From c16a922d53efd9d2d47723246f8a37e0a475af87 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominykas=20Blyz=CC=8Ce=CC=87?= Date: Fri, 15 Dec 2023 12:57:37 +0200 Subject: [PATCH] Note that `helm lint` should warn about git deps MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Dominykas Blyžė --- hips/hip-00NN.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hips/hip-00NN.md b/hips/hip-00NN.md index 3044b57b..9afc2426 100644 --- a/hips/hip-00NN.md +++ b/hips/hip-00NN.md @@ -55,6 +55,8 @@ dependencies: version: "main" ``` +### Installation + When Helm is installing a dependency from git, it should: - create a temporary directory @@ -64,6 +66,10 @@ When Helm is installing a dependency from git, it should: - treat the cloned git repo similar to a `file:///path/to/temp/dir` style requirement; use `chart.LoadDir` to load that directory (which in turn applied the logic for filtering the files through `.helmignore`) and archives it to `charts/` - delete the temp dir +### Linting + +`helm lint` should print a warning when a chart contains a git-based dependency, primarily because git references are mutable. + ## Backwards compatibility This is backwards compatible from Helm perspective - the existing formats for `dependencies` are still supported.