From e211f2aa62992bd72586b395de50979e31231829 Mon Sep 17 00:00:00 2001 From: Matt Farina Date: Wed, 22 May 2024 14:05:24 -0400 Subject: [PATCH] Fixing build issue where wrong version is used The release process had selected the tag to use as the version automatically. But, this presented a problem when a release candidate and final release pointed to the same commit id. For a long time it had automatically selected the final release. But, we ran into a problem where it selected the RC tag instead of the final release. This change explicitly tells the build scripts the version to use based on the tag passed into the CI run. It should no longer try to self discover the version. Closes #13040 Signed-off-by: Matt Farina (cherry picked from commit 0b64775386001ec61d02980d1218d834348b10c4) --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 8b69f10ddcc..6d27899b66b 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -34,7 +34,7 @@ jobs: run: | set -eu -o pipefail - make build-cross + make build-cross VERSION="${{ github.ref_name }}" make dist checksum VERSION="${{ github.ref_name }}" - name: Set latest version