New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory leak in the upgrade action #10439
Labels
bug
Categorizes issue or PR as related to a bug.
Comments
jkmw
added a commit
to jkmw/helm
that referenced
this issue
Dec 6, 2021
jkmw
added a commit
to jkmw/helm
that referenced
this issue
Dec 6, 2021
fixes helm#10439 Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
3 tasks
zak905
pushed a commit
to zak905/helm
that referenced
this issue
Jan 19, 2023
fixes helm#10439 Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
add #11805 as the same issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
During the upgrade action we noticed a memory leak which only occurs when helm is used as a "library" and not as a cli tool.
Actually, there are two places:
The
performUpgrade
method waits at this point for therChan
, which is either filled by thereleasingUpgrade
orhandleContext
method. If the result comes fromreleasingUpgrade()
, thenhandleContext()
will wait until the context (ctx
) is cancelled, which in most cases will never happen and keeps the routine running.If
ctx
is indeed cancelled,handleContext()
callsreportToPerformUpgrade()
which fills the already consumedrChan
. However, this is never read because the only consumer (performUpgrade()
) has already returned; The routine remains running forever.Output of
helm version
:The text was updated successfully, but these errors were encountered: