New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting the NOTES.txt data from a subchart #2751

Open
dfee opened this Issue Aug 2, 2017 · 12 comments

Comments

Projects
None yet
@dfee

dfee commented Aug 2, 2017

Let's say I've got a dependency on postgresql:

dependencies:
  - name: postgresql
    version: 0.7.1
    repository: https://kubernetes-charts.storage.googleapis.com

If I install my chart (helm install .), it doesn't seem possible to get the (rather helpful) notes from the postgresql subchart. I.e. helm status my-chart does not list the notes for postgresql, only what's listed in templates/NOTES.txt.

Is there a workaround?

@jeff-knurek

This comment has been minimized.

jeff-knurek commented Aug 2, 2017

I'm annoyed by this apparent "lack of functionality" too.
I also couldn't find any solutions in the helm-users Slack channel, but I did find this PR #1409 that seemed to make it so only the parent's NOTES is shown.

@jascott1

This comment has been minimized.

Collaborator

jascott1 commented Aug 3, 2017

Related to (but not a duplicate of) #2742 feature request "refetch notes".

@iamrandys

This comment has been minimized.

iamrandys commented Nov 1, 2017

👍

@sylus

This comment has been minimized.

sylus commented Dec 19, 2017

Tripped me up as well today, glad to know is an issue :)

@kiich

This comment has been minimized.

Contributor

kiich commented Jan 5, 2018

+1 for this issue - we have our "main" chart which all of our charts depend on and would be good to just change the NOTES.txt in that one place.

@fejta-bot

This comment has been minimized.

fejta-bot commented Apr 5, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@thomas-riccardi

This comment has been minimized.

thomas-riccardi commented Apr 5, 2018

/remove-lifecycle stale

@bacongobbler

This comment has been minimized.

Member

bacongobbler commented Apr 27, 2018

We'd happily accept a PR if someone wants to take this on. This would be a great feature to have, and it shouldn't be too much work. I'll leave this one open as an opportunity for someone who wants to get their feet wet with Helm.

@teaguecole

This comment has been minimized.

teaguecole commented Apr 28, 2018

Hi! I just started contributing to one of the kubernetes incubator project, which exposed me to helm. Furthermore the helm-dev channel was created on my birthday, so this project is calling my name. I would be more than happy to get my feet wet with this issue. So I am officially calling dibs.

@mattfarina

This comment has been minimized.

Collaborator

mattfarina commented May 16, 2018

@teaguecole Did you start working on this one?

@teaguecole

This comment has been minimized.

teaguecole commented May 16, 2018

@mattfarina I have not... I was going to, but I probably have taken too much on my plate from another SIG... If you want to snatch it from me, you can take it. Thanks for reminding me, I was going to release it to the wild in case others want to jump on it.

@jgleonard

This comment has been minimized.

jgleonard commented May 31, 2018

@bacongobbler can you take a look at #4088 for this? Realizing that the patch is in Tiller, it may need some other changes for Helm3... Thoughts?

tedmiston added a commit to astronomer/helm.astronomer.io that referenced this issue Jul 12, 2018

Add WIP future top-level notes
- When installing an umbrella chart, subcharts notes are not run/shown (open issue @ helm/helm#2751)
- With Docker for Mac the local IP is 127.0.0.1 but this is different for Minikube

tedmiston added a commit to astronomer/helm.astronomer.io that referenced this issue Jul 12, 2018

@bacongobbler bacongobbler added feature and removed kind/feature labels Jul 30, 2018

jgleonard added a commit to jgleonard/helm that referenced this issue Nov 1, 2018

fix(helm): add --render-subchart-notes flag to 'helm install' and 'he…
…lm upgrade'

When 'helm <install|upgrade> --render-subchart-notes ...' is run, this will include
the notes from the subchart when rendered via Tiller.

Closes helm#2751

Signed-off-by: Jon Leonard <jon.leonard@sanofi.com>

jgleonard added a commit to jgleonard/helm that referenced this issue Nov 1, 2018

fix(helm): add --render-subchart-notes flag to 'helm install' and 'he…
…lm upgrade'

When 'helm <install|upgrade> --render-subchart-notes ...' is run, this will include
the notes from the subchart when rendered via Tiller.

Closes helm#2751

Signed-off-by: Jon Leonard <jon.leonard@sanofi.com>

jgleonard added a commit to jgleonard/helm that referenced this issue Nov 1, 2018

fix(helm): add --render-subchart-notes flag to 'helm install' and 'he…
…lm upgrade'

When 'helm <install|upgrade> --render-subchart-notes ...' is run, this will include
the notes from the subchart when rendered via Tiller.

Closes helm#2751

Signed-off-by: Jon Leonard <jgleonard@gmail.com>

jgleonard added a commit to jgleonard/helm that referenced this issue Nov 1, 2018

fix(helm): add --render-subchart-notes flag to 'helm install' and 'he…
…lm upgrade'

When 'helm <install|upgrade> --render-subchart-notes ...' is run, this will include
the notes from the subchart when rendered via Tiller.

Closes helm#2751

Signed-off-by: Jon Leonard <jgleonard@gmail.com>
Signed-off-by: Jon Leonard <jon.leonard@sanofi.com>
Signed-off-by: Jon Leonard <jgleonard@gmail.com>

jgleonard added a commit to jgleonard/helm that referenced this issue Nov 1, 2018

fix(helm): add --render-subchart-notes flag to 'helm install' and 'he…
…lm upgrade'

When 'helm <install|upgrade> --render-subchart-notes ...' is run, this will include
the notes from the subchart when rendered via Tiller.

Closes helm#2751

Signed-off-by: Jon Leonard <jgleonard@gmail.com>
Signed-off-by: Jon Leonard <jon.leonard@sanofi.com>
Signed-off-by: Jon Leonard <jgleonard@gmail.com>

jgleonard added a commit to jgleonard/helm that referenced this issue Nov 1, 2018

fix(helm): add --render-subchart-notes flag to 'helm install' and 'he…
…lm upgrade'

When 'helm <install|upgrade> --render-subchart-notes ...' is run, this will include
the notes from the subchart when rendered via Tiller.

Closes helm#2751

Signed-off-by: jgleonard <jgleonard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment