New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--reuse-values does not work as expected with requirements conditions #2948
Comments
I think this might be a more general issue with using --set on nested values. Setting one value appears to remove the entire subtree and only append the set node, even when using --reuse-values. |
Having a similar problem. We install a master chart (with many subcharts) and a large value set with subchart:
image:
tag: HASH As the OP, I'd expect the entire coalesced value tree from the previous release. We're using v2.7.0 |
Our problem was on our end. It was a combination of misunderstanding what |
I have also encountered this error with Helm v2.7.2. It seems that condition in requirements.yaml doesn't reuse values from previous install even though |
Is there any update on this one? I'm seeing subcharts disappearing just by doing a |
I can't speak to Helm core, but I did port Helm to Java and the client-side processing involving Indeed, conditions and tags work at a high level by effectively causing chart surgery to be done in memory before the chart to be rendered crosses the wire to Tiller. So, by the time Tiller has the chart and its values to render, the chart it actually has is the synthetic one made by removing certain parts of the original. |
@ljnelson Pros and cons. Filtering on the client side means you can have much larger trees of charts that don’t blow the size limits by sending charts that will never be used. openstack/kolla-kubernetes is three levels deep and has ~twenty 2nd level charts and each of those contain 3rd level charts. We have about two hundred 3rd level charts. I am convinced this is a bug and will check into it and see if I can come up with a solution. |
It adds to the frustration that this isn't documented. At the very least it should be made clear that you can not use |
@tsloughter Sorry you are having trouble. It is a bug, thats why the behavior is not documented. |
2.10 was released and based on the changelog this is still a bug? I really think the docs should mention it, as a bug, no reason someone reading the docs should get the impression this works and have to find out the hard way it doesn't. |
@tsloughter if you'd like to take a crack at a PR to mention this, we'd really appreciate it. We have very limited resources so we'd really appreciate the help in taking the time to make a PR. :) |
Any plan to get this fixed or at least better documented? This is hell to use :) |
Same issue here. It is very frustrating. |
Im labeling this v3 to ensure its looked at for the new version but it does not preclude a 2x fix. |
fixed in Helm 3 via #6556. |
What happened:
I have a simple chart with a subchart installed. In the
requirements.yaml
I havecondition: subchart.enabled
Check out my gist of the the chart including bug-example-0-1-0-tgz:
I see both the subchart and chart are installed. Now when I upgrade with
--reuse-values
I see that my subchart template is not included:What you expected to happen:
The subchart is included in the upgrade.
The text was updated successfully, but these errors were encountered: