New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm3: was Release.Namespace removed from helm3 build in objects on purpose? #4255

Closed
jstrachan opened this Issue Jun 21, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@jstrachan
Copy link
Contributor

jstrachan commented Jun 21, 2018

as how else can we inject the namespace where a chart is being installed into?

I got a regression when trying to install the chart stable/nginx-ingress chart:

$ helm3 install --name jxing stable/nginx-ingress --namespace kube-system --set rbac.create=true
ClusterRoleBinding.rbac.authorization.k8s.io "jxing-nginx-ingress" is invalid: subjects[0].namespace: Required value

as this value is no longer substituted:
https://github.com/kubernetes/charts/blob/master/stable/nginx-ingress/templates/rolebinding.yaml#L18

@bacongobbler

This comment has been minimized.

Copy link
Member

bacongobbler commented Jun 21, 2018

@jstrachan I'm going to close this because we decided last dev call that we are not going to be tracking issues for Helm 3 at this point since it's still very much in-flux and things are expected to change.

If you have any further discussion points/issues/questions regarding Helm 3, if you wouldn't mind discussing in #helm-dev in Slack that would be most appreciated. Thanks!

jstrachan referenced this issue Jun 22, 2018

feat(*): remove Time, Namespace, and Revision from template functions
Removes Time, Namespace, and Revision from being exposed to templates to
make template rendering discrete and repeatable.

jstrachan added a commit to jstrachan/helm that referenced this issue Jun 22, 2018

fix: bring back Release.Namespace
any chart which uses `RoleBinding` or `ClusterRoleBinding` needs a way to populate the namespace being used for a release - such as to reference a `ServiceAccount` in a `RoleBinding`. Removing support for `Release.Namespace` breaks many charts.

Given the namespace being used to install/update a chart is typically fixed; am not sure there's a great reason for its removal - as its totally repeatable.

fixes helm#4255

jstrachan added a commit to jstrachan/helm that referenced this issue Jun 22, 2018

@adamreese

This comment has been minimized.

Copy link
Member

adamreese commented Jun 22, 2018

It will be added back. The goal for now is to have a template rendering step that can create resources to add to any namespace

@ysaakpr

This comment has been minimized.

Copy link

ysaakpr commented Jul 12, 2018

I am getting the similar error in helm 2 as well.
helm install -n jxing jenkins-x/nginx-ingress --values jxing-nginx-ingress-values.yaml --namespace kube-system --version 0.21.0

Error: release jxing failed: ClusterRoleBinding.rbac.authorization.k8s.io "jxing-nginx-ingress" is invalid: subjects[0].namespace: Required value

helm version
Client: &version.Version{SemVer:"v2.9.1", GitCommit:"20adb27c7c5868466912eebdf6664e7390ebe710", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.9.1", GitCommit:"20adb27c7c5868466912eebdf6664e7390ebe710", GitTreeState:"clean"}
@bacongobbler

This comment has been minimized.

Copy link
Member

bacongobbler commented Jul 12, 2018

@ysaakpr I'd follow up with the Jenkins X team maintaining that chart directly. Looks like a chart usage issue rather than the issue listed here.

CC @jstrachan ^ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment