Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiVersion still v1 in Helm v3 #5907

Closed
mattfarina opened this issue Jun 18, 2019 · 8 comments

Comments

@mattfarina
Copy link
Collaborator

commented Jun 18, 2019

The apiVersion in charts for Helm v3 is v1. Yet, there have been some chart changes including:

  • dependencies moved to the Chart.yaml file
  • requirements.lock is now Chart.lock
  • annotations added to the Chart.yaml file

I understand that Helm v3 works for both the older and newer setups. But, external tools that work with charts don't know about the changes.

Should we move the apiVersion to v2?

@bacongobbler

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

slating to get this done before we release the first beta.

@hickeyma

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

@mattfarina @bacongobbler I can work on this if it is open to be done?

@bacongobbler

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

Sure!

@hickeyma

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

Here are the tasks required:

  • Update scaffold chart to be "v2" (#6106)
  • Update linting to handle new dependencies and annotations (#6117)
  • Helm 2 should fail to load a chart with an apiVersion field of anything other than v1 or the empty string (#6180)
  • Update documentation to specify "v2" as default version and "v1" for specific scenarios (helm/helm-www#255)
@bacongobbler

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

Additional TODO:

  • Helm 2 should fail to load a chart with an apiVersion field of anything other than v1 or the empty string

Helm 2 doesn't validate the apiVersion field, so those charts are assumed to be compiled against apiVersion v1. Older versions of Helm should fail to load charts that were built for a newer version of the spec it doesn't understand.

@hickeyma

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

Thanks @bacongobbler for the heads up in #5907 (comment). I have added it to the task list in #5907 (comment).

@bacongobbler

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

all of the PRs for the tasks have been merged so this can now be closed :)

@hickeyma

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

Thanks @bacongobbler for the doc PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.