Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Helm 3: Test Enhancement Proposal #6020
3.x and Beyond
Some of the desired features for
Continuing to share the hooks annotation-based API with
None of the enhancements outlined in this issue are likely to be blocked by continuing to use the hooks API, however in the future there is a possibility that the hooks API will not be sufficient for some unforeseen testing use cases. We have the opportunity to make a breaking change in Helm 3 and move to a separate API for test annotations which could evolve independently of hooks, however this comes at a large cost and may be premature if we lack well defined use cases predicated on the API.
Excellent write up @jlegrone. I think you've come up with an excellent proposal and I appreciate your perspective as an end user. It's a good evolution from what
Thanks for the write-up @jlegrone. As discussed in the call, it may make sense to work on the infrastructure to support these use cases so we can avoid delaying a 3.0 release. Laying out the groundwork would be a good first step, then we can start discussing feature additions proposed, such as log streaming support, Job support, etc. in a future 3.x release. If we can get those feature addtions done before 3.0, that's great, but we should make sure that we have a solid foundation to work upon to ensure we can make this work happen without having to break compatibility.
Are you looking to do this work yourself, or are you looking for others to implement the work? Just trying to gauge what needs to happen to get the ball rolling on this. Thanks!
We'll support whatever is supported by hooks in helm 3. I wouldn't mind switching entirely to jobs but that would be a pretty major change so it's probably best to continue supporting both.
This should be possible with the
annotations: helm.sh/hook-delete-policy: before-hook-creation
Or only skip cleanup on failure:
annotations: helm.sh/hook-delete-policy: hook-succeeded
Right now the plan is to work with @michelleN on implementing required changes for 3.0, and we can break out new features for 3.1+ releases into independent github issues. I'm definitely happy to take on some of the development effort!