Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm template throws stack overflow error when trying to use file checksum #7111

Closed
algorunescu opened this issue Nov 29, 2019 · 6 comments · Fixed by #7114
Closed

Helm template throws stack overflow error when trying to use file checksum #7111

algorunescu opened this issue Nov 29, 2019 · 6 comments · Fixed by #7114
Assignees
Labels

Comments

@algorunescu
Copy link

@algorunescu algorunescu commented Nov 29, 2019

Output of helm version:
version.BuildInfo{Version:"v3.0.0", GitCommit:"e29ce2a54e96cd02ccfce88bee4f58bb6e2a28b6", GitTreeState:"clean", GoVersion:"go1.13.4"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-08T17:11:31Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.3-k3s.2", GitCommit:"e7e6a3c4e9a7d80b87793612730d10a863a25980", GitTreeState:"clean", BuildDate:"2019-11-18T18:31:23Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
k3s

Helm template blows up when trying to use checksums. To reproduce it, simply create a helm chart with "helm create" then edit the deployment.yaml so the spec template contains:
...
template:
metadata:
annotations:
checksum/config: {{ include (print $.Template.BasePath "/deployment.yaml") . | sha256sum }}
...

Try to generate the manifests with: "helm template --output-dir manifests". You will get something like the log attached.
This of course affects any other commands that rely on generating the manifests like "helm install".

log.txt

@zwwhdls

This comment has been minimized.

Copy link
Contributor

@zwwhdls zwwhdls commented Nov 29, 2019

/assign

I have found an error about recursive. I will create a pr to fix it. 😊

@hickeyma

This comment has been minimized.

Copy link
Contributor

@hickeyma hickeyma commented Nov 29, 2019

Reproduced the stack trace. Thanks for finding this @algorunescu.

@zwwhdls It would be great if you can work on the PR. I assigned the issue to you.

zwwhdls added a commit to zwwhdls/helm that referenced this issue Nov 29, 2019
zwwhdls added a commit to zwwhdls/helm that referenced this issue Nov 29, 2019
Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
hickeyma added a commit that referenced this issue Dec 2, 2019
* fixed #7111

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* update error message

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* add test case

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* fix lint error

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
@hickeyma

This comment has been minimized.

Copy link
Contributor

@hickeyma hickeyma commented Dec 2, 2019

@algorunescu Fix #7114 has been merged for this issue. Closing the issue.

@hickeyma

This comment has been minimized.

Copy link
Contributor

@hickeyma hickeyma commented Dec 2, 2019

Back-Port to v2 in PR #7128

@hickeyma hickeyma added the v2.x label Dec 2, 2019
@hickeyma hickeyma reopened this Dec 2, 2019
@hickeyma

This comment has been minimized.

Copy link
Contributor

@hickeyma hickeyma commented Dec 2, 2019

Re-opening as need fix in v2 also.

jmcelwain added a commit to jmcelwain/helm that referenced this issue Dec 5, 2019
* fixed helm#7111

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* update error message

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* add test case

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* fix lint error

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
jmcelwain added a commit to jmcelwain/helm that referenced this issue Dec 5, 2019
* fixed helm#7111

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* update error message

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* add test case

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* fix lint error

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
mattfarina added a commit that referenced this issue Dec 5, 2019
* fixed #7111

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* update error message

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* add test case

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>

* fix lint error

Signed-off-by: zwwhdls <zwwhdls@hotmail.com>
(cherry picked from commit 750b870)
@hickeyma

This comment has been minimized.

Copy link
Contributor

@hickeyma hickeyma commented Dec 11, 2019

v2 back port in #7128 merged. Closing.

@hickeyma hickeyma closed this Dec 11, 2019
@hickeyma hickeyma self-assigned this Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.