New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm repo index changing created timestamp #7363
Comments
There is an "ugly" workaround:
Hoping there is a cleaner way to do this. |
At first glance, this seems intentional.
Let us know how you get along. |
I agree that the linked script replicates what my workaround described above. However, the digest to the previous chart versions doesn't change. Shouldn't updates to existing chart definitions be predicated on a change to the digest as well? |
I was also expecting the behavior where existing entries had the In our case we maintain a simple Helm repository on the file system and just re-run |
This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs. |
The command `helm repo index` is changing timestamps for already existing charts. This seems to be intended: helm/helm#7363 Helm stable repo tests use this workaround: https://github.com/helm/charts/blob/c6e503ccfd9911dd06ea9ac389a40a3490637516/test/repo-sync.sh#L83-L90 This commit adds the mentioned workaround to our build.
The command `helm repo index` is changing timestamps for already existing charts. This seems to be intended: helm/helm#7363 Helm stable repo tests use this workaround: https://github.com/helm/charts/blob/c6e503ccfd9911dd06ea9ac389a40a3490637516/test/repo-sync.sh#L83-L90 This commit adds the mentioned workaround to our build.
The command `helm repo index` is changing timestamps for already existing charts. This seems to be intended: helm/helm#7363 Helm stable repo tests use this workaround: https://github.com/helm/charts/blob/c6e503ccfd9911dd06ea9ac389a40a3490637516/test/repo-sync.sh#L83-L90 This commit adds the mentioned workaround to our build.
closing as stale. |
Summary: We should only update the `created` field for the new Helm package in the Helm repo. There's a `--merge` field to allow for this in `helm package`, but it requires some unfortunate manuevers to get right. See issue helm/helm#7363 (comment) for more details. Test Plan: ``` dagster-release helm -p helm/dagster -r ../helm/ -v 0.11.3 --dry-run dagster-release helm -p helm/dagster/charts/dagster-user-deployments -r ../helm/ -v 0.11.3 --dry-run ``` Reviewers: johann, alangenfeld Reviewed By: johann Differential Revision: https://dagster.phacility.com/D7257
Output of
helm version
: version.BuildInfo{Version:"v3.0.2", GitCommit:"19e47ee3283ae98139d98460de796c1be1e3975f", GitTreeState:"clean", GoVersion:"go1.13.5"}When I do a
helm repo index .
it will redo all entries in my index.yaml file (including existing ones) updating the timestamp of the files.This is an issue because of the recommended build process for using Github pages to host a repo.
When I do a
github checkout gh-pages
my existing chart package binaries and index.yaml file will get a new timestamp. So when you do a helm repo index attempting to include a new version of your chart, the created property for each prior chart also gets updated with the new timestamps.Should
helm repo index .
not update the created timestamp if no other properties for existing charts have changed or do we need a new command line option to force this behavior?The text was updated successfully, but these errors were encountered: