New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/missing ssl params #3152
Fix/missing ssl params #3152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed in a pairing session, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs need updating :)
helm docs are out of date. Please run "make docs"
c0a2d71
to
43977d9
Compare
|
mind rebasing your PR as well? looks like a merge commit strayed in here. Sorry! |
During a recent refactor, several TLS flags stopped being processed for a few of the commands. This fixes those commands, and documents how to set up TLS.
The older version of Tiller allowed a weaker set of certificate checks than we intended. This version requires a client certificate, and then requires that that certificate be signed by a known CA. This works around the situation where a user could provide a self-signed certificate.
43977d9
to
1096813
Compare
|
Ah! Yes, I rebased off the wrong commit. I think I fixed it. |
* fix(helm): add TLS params back During a recent refactor, several TLS flags stopped being processed for a few of the commands. This fixes those commands, and documents how to set up TLS. * fix(tiller): add stricter certificate verification The older version of Tiller allowed a weaker set of certificate checks than we intended. This version requires a client certificate, and then requires that that certificate be signed by a known CA. This works around the situation where a user could provide a self-signed certificate. (cherry picked from commit e8e6ac5)
* fix(helm): add TLS params back During a recent refactor, several TLS flags stopped being processed for a few of the commands. This fixes those commands, and documents how to set up TLS. * fix(tiller): add stricter certificate verification The older version of Tiller allowed a weaker set of certificate checks than we intended. This version requires a client certificate, and then requires that that certificate be signed by a known CA. This works around the situation where a user could provide a self-signed certificate. (cherry picked from commit e8e6ac5)
Fix several issues with SSL, including:
helm get *helm list