Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed an issue with the canaray rudder image in versioning.mk #3653

Merged
merged 1 commit into from Mar 16, 2018

Conversation

Projects
None yet
4 participants
@robbert229
Copy link
Contributor

robbert229 commented Mar 10, 2018

Currently we specify the canary docker images should use the git version when they should be using the mutable version.

The following code is the area in question.

MUTABLE_IMAGE        := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME}:${MUTABLE_VERSION}
MUTABLE_IMAGE_RUDDER := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME_RUDDER}:${DOCKER_VERSION}

I am fairly certain that we should be using MUTABLE_VERSION instead of DOCKER_VERSION in MUTABLE_IMAGE_RUDDER

fixed an issue in versioning.mk
The MUTABLE_IMAGE_RUDDER variables was using the DOCKER_VERSION instead of MUTABLE_VERSION
```
MUTABLE_IMAGE        := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME}:${MUTABLE_VERSION}
MUTABLE_IMAGE_RUDDER := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME_RUDDER}:${DOCKER_VERSION}
```

@robbert229 robbert229 changed the title fixed an issue in versioning.mk fixed an issue with the canaray rudder image in versioning.mk Mar 10, 2018

@thomastaylor312 thomastaylor312 added this to the 2.9.0 - Features milestone Mar 13, 2018

@adamreese adamreese merged commit a53f93c into helm:master Mar 16, 2018

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
cla/linuxfoundation robbert229 authorized
Details

splisson added a commit to splisson/helm that referenced this pull request Dec 6, 2018

fixed an issue in versioning.mk (helm#3653)
The MUTABLE_IMAGE_RUDDER variables was using the DOCKER_VERSION instead of MUTABLE_VERSION
```
MUTABLE_IMAGE        := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME}:${MUTABLE_VERSION}
MUTABLE_IMAGE_RUDDER := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME_RUDDER}:${DOCKER_VERSION}
```

splisson pushed a commit to splisson/helm that referenced this pull request Dec 6, 2018

fixed an issue in versioning.mk (helm#3653)
The MUTABLE_IMAGE_RUDDER variables was using the DOCKER_VERSION instead of MUTABLE_VERSION
```
MUTABLE_IMAGE        := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME}:${MUTABLE_VERSION}
MUTABLE_IMAGE_RUDDER := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME_RUDDER}:${DOCKER_VERSION}
```

jianghang8421 added a commit to jianghang8421/helm that referenced this pull request Feb 17, 2019

fixed an issue in versioning.mk (helm#3653)
The MUTABLE_IMAGE_RUDDER variables was using the DOCKER_VERSION instead of MUTABLE_VERSION
```
MUTABLE_IMAGE        := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME}:${MUTABLE_VERSION}
MUTABLE_IMAGE_RUDDER := ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${SHORT_NAME_RUDDER}:${DOCKER_VERSION}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.