New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bring back Release.Namespace #4257

Closed
wants to merge 2 commits into
base: dev-v3
from

Conversation

Projects
None yet
4 participants
@jstrachan
Copy link
Contributor

jstrachan commented Jun 22, 2018

any chart which uses RoleBinding or ClusterRoleBinding needs a way to populate the namespace being used for a release - such as to reference a ServiceAccount in a RoleBinding. Removing support for Release.Namespace breaks many charts.

Given the namespace being used to install/update a chart is typically fixed; am not sure there's a great reason for its removal - as its totally repeatable.

fixes #4255

fix: bring back Release.Namespace
any chart which uses `RoleBinding` or `ClusterRoleBinding` needs a way to populate the namespace being used for a release - such as to reference a `ServiceAccount` in a `RoleBinding`. Removing support for `Release.Namespace` breaks many charts.

Given the namespace being used to install/update a chart is typically fixed; am not sure there's a great reason for its removal - as its totally repeatable.

fixes #4255

@bacongobbler bacongobbler added the v3 label Jun 22, 2018

@jstrachan

This comment has been minimized.

Copy link
Contributor

jstrachan commented Jun 22, 2018

This PR basically reverts the changes in commit: aa859e3 which apply to Release.Namespace but keeps all the removals of Release.Time and Release.Revision

@adamreese

This comment has been minimized.

Copy link
Member

adamreese commented Jun 22, 2018

The purpose of that change is to keep template rendering and resource creation separate. The dev v3 branch is not yet open for PR's. But thanks for taking a look.

@adamreese adamreese closed this Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment