Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing many typos in docs #5324

Merged
merged 1 commit into from Apr 16, 2019
Merged

Fixing many typos in docs #5324

merged 1 commit into from Apr 16, 2019

Conversation

tuanvcw
Copy link

@tuanvcw tuanvcw commented Feb 19, 2019

This PR fixes many typos in docs

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 19, 2019
@mattfarina
Copy link
Collaborator

@tuanvcw Can you run make docs on this change. That is why CI is failing. Some docs are autogenerated. The root needs to be fixed and then the other docs generated.

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 25, 2019
@tuanvcw
Copy link
Author

tuanvcw commented Feb 25, 2019

Hi @mattfarina
Thank you very much! I've just run make docs as your suggestion.
Wish you a great day ahead :)

Copy link
Contributor

@hickeyma hickeyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit change

@@ -150,7 +150,7 @@ Template functions and pipelines are a powerful way to transform information and

## Operators are functions

Operators are implemented as functions that return a boolean value. To use `eq`, `ne`, `lt`, `gt`, `and`, `or`, `not` etcetera place the operator at the front of the statement followed by its parameters just as you would a function. To chain multiple operations together, separate individual functions by surrounding them with paranthesis.
Operators are implemented as functions that return a boolean value. To use `eq`, `ne`, `lt`, `gt`, `and`, `or`, `not` etcetera place the operator at the front of the statement followed by its parameters just as you would a function. To chain multiple operations together, separate individual functions by surrounding them with parenthesis.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parenthesis --> parentheses

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, this has been updated as your recommendation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuanvcw I do not see the changes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hickeyma, sorry I forgot to push the new change.
The patch has just been updated, thanks a lot 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bother

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2019
Signed-off-by: Vu Cong Tuan <tuanvc@vn.fujitsu.com>
Copy link
Contributor

@hickeyma hickeyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@tuanvcw
Copy link
Author

tuanvcw commented Mar 4, 2019

Hi @mattfarina and @hickeyma,
Thanks for your kind reviews, if there's anything else I could do to move this PR forward, please feel free to let me know.
Have a great day 😄

@mattfarina mattfarina merged commit 029f6a2 into helm:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants