Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding github workflow for contributing to helm #5346

Merged
merged 1 commit into from Apr 25, 2019

Conversation

Projects
None yet
5 participants
@truongnh1992
Copy link
Contributor

commented Feb 22, 2019

Describe detail step-by-step of using github to contribute to
helm project.

Co-Authored-By: Dao Cong Tien tiendc@vn.fujitsu.com
Signed-off-by: Nguyen Hai Truong truongnh@vn.fujitsu.com

@helm-bot helm-bot added the size/M label Feb 22, 2019

@mattfarina
Copy link
Collaborator

left a comment

Thanks for your interest in our contributions process. This type of content should be in the CONTRIBUTING.md file. That is the standard file name GitHub expects. Some of this is already in that file. Would you mind trying to make the improvements there.

@truongnh1992 truongnh1992 force-pushed the truongnh1992:github_workflow branch from 38cc7d5 to 570ed73 Feb 22, 2019

@helm-bot helm-bot added size/M and removed size/M labels Feb 22, 2019

@truongnh1992 truongnh1992 force-pushed the truongnh1992:github_workflow branch from 570ed73 to 27e2b7e Feb 22, 2019

@helm-bot helm-bot added size/M and removed size/M labels Feb 22, 2019

@truongnh1992 truongnh1992 force-pushed the truongnh1992:github_workflow branch from 27e2b7e to 86cebf8 Feb 22, 2019

@helm-bot helm-bot added size/M and removed size/M labels Feb 22, 2019

@truongnh1992

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

Thanks for your interest in our contributions process. This type of content should be in the CONTRIBUTING.md file. That is the standard file name GitHub expects. Some of this is already in that file. Would you mind trying to make the improvements there.

I've just resolved your comment, the content of CONTRIBUTING.md has been updated.

Show resolved Hide resolved CONTRIBUTING.md Outdated
Show resolved Hide resolved CONTRIBUTING.md Outdated
Show resolved Hide resolved CONTRIBUTING.md Outdated
Show resolved Hide resolved CONTRIBUTING.md Outdated
Show resolved Hide resolved CONTRIBUTING.md Outdated
Show resolved Hide resolved CONTRIBUTING.md Outdated
Show resolved Hide resolved CONTRIBUTING.md Outdated
Show resolved Hide resolved CONTRIBUTING.md
Show resolved Hide resolved CONTRIBUTING.md Outdated
@bacongobbler

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

Why were the file permissions on CONTRIBUTING.md changed from 100644 to 100755?

@truongnh1992 truongnh1992 force-pushed the truongnh1992:github_workflow branch from 86cebf8 to a5496f0 Feb 23, 2019

@helm-bot helm-bot added size/M and removed size/M labels Feb 23, 2019

Adding github workflow for contributing to helm
Describe detail step-by-step of using github to contribute to
helm project.

Co-Authored-By: Dao Cong Tien tiendc@vn.fujitsu.com
Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>

@truongnh1992 truongnh1992 force-pushed the truongnh1992:github_workflow branch from a5496f0 to 7d2e426 Feb 23, 2019

@helm-bot helm-bot added size/M and removed size/M labels Feb 23, 2019

@truongnh1992

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2019

Why were the file permissions on CONTRIBUTING.md changed from 100644 to 100755?

@bacongobbler Thank you for your review. I've already resolved all of your changes request.

@truongnh1992

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

@mattfarina could you help me to review this change, please.

@mattfarina mattfarina merged commit dcb81c9 into helm:master Apr 25, 2019

3 checks passed

DCO DCO
Details
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@mattfarina

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

@truongnh1992 Thanks for the PR. We discussed it in the Helm Dev Call. It was a useful conversation.

@truongnh1992

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

@truongnh1992 Thanks for the PR. We discussed it in the Helm Dev Call. It was a useful conversation.

You're welcome. I'm willing to contribute to opensource project. By the way, how can I become a member of helm org on Github?

@mattfarina

This comment has been minimized.

Copy link
Collaborator

commented Apr 30, 2019

@truongnh1992 You can contribute without being a member of the Helm org on GitHub. The members of the org are those who have been or currently are maintaining a project that is part of Helm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.