Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: remove pkg/helm, pkg/hapi, pkg/tiller #5365

Merged
merged 9 commits into from Mar 13, 2019

Conversation

@bacongobbler
Copy link
Member

commented Feb 26, 2019

This is a massive internal refactoring of pkg/, removing the helm, hapi and tiller packages, refactoring the code into pkg/action, and refactoring cmd/helm to rely on the action package.

TODO:

  • comb through the code, making sure imports look right and the code is in the right place
  • manually test to ensure everything works
    - [ ] move functions like newInstallCmd into pkg/cli to accommodate #5311 deferred

Signed-off-by: Matthew Fisher matt.fisher@microsoft.com

ref: remove pkg/helm, pkg/hapi, pkg/tiller
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

@bacongobbler bacongobbler force-pushed the bacongobbler:remove-pkg-tiller branch from aba56dc to 2571dbf Mar 12, 2019

@helm-bot helm-bot added size/XXL and removed size/XXL labels Mar 12, 2019

@bacongobbler bacongobbler changed the title WIP: ref: remove pkg/helm, pkg/hapi, pkg/tiller ref: remove pkg/helm, pkg/hapi, pkg/tiller Mar 12, 2019

Helm 3 automation moved this from In Progress to Awaiting Review Mar 12, 2019

@adamreese
Copy link
Member

left a comment

  • Add back release_testing_test.go unit tests
  • Clean up old golden files rm ./cmd/helm/testdata/output/* && go test ./cmd/helm -update
@@ -37,24 +33,9 @@ func TestTemplateCmd(t *testing.T) {
},
{
name: "check set name",
cmd: fmt.Sprintf("template '%s' -x '%s' --set service.name=apache", chartPath, filepath.Join("templates", "service.yaml")),
cmd: fmt.Sprintf("template '%s' --set service.name=apache", chartPath),

This comment has been minimized.

Copy link
@adamreese

adamreese Mar 12, 2019

Member

Add -x flag back?

This comment has been minimized.

Copy link
@bacongobbler

bacongobbler Mar 13, 2019

Author Member

According to @technosophos this was intentional in preparation for the Lua engine. He wasn't sure if we wanted to allow partial template execution as it may mess up how the Lua engine depends on certain templates. However, we currently don't have Lua engine support so this could be premature. I'm happy to add this back and we can revisit that conversation when we add Lua support in here though. What do you think about that?

cmd/helm/testdata/output/status-with-notes.txt Outdated Show resolved Hide resolved
pkg/action/pull.go Outdated Show resolved Hide resolved
fix(helm): fix `helm status` output formatting
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

@helm-bot helm-bot added size/XXL and removed size/XXL labels Mar 13, 2019

cmd/helm/release_testing.go Show resolved Hide resolved
test(cmd): refactor release_testing_test.go
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

@helm-bot helm-bot added size/XXL and removed size/XXL labels Mar 13, 2019

fix(action): remove test.go
test.go is a duplicate of release_testing.go

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

@helm-bot helm-bot added size/XXL and removed size/XXL labels Mar 13, 2019

@bacongobbler

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

  • Add back release_testing_test.go unit tests
  • Clean up old golden files rm ./cmd/helm/testdata/output/* && go test ./cmd/helm -update

done

ref(cmd): remove mockTestSuccessTemplate
unused code

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

@helm-bot helm-bot added size/XXL and removed size/XXL labels Mar 13, 2019

style(cmd): go fmt
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

@helm-bot helm-bot added size/XXL and removed size/XXL labels Mar 13, 2019

pkg/action/show.go Outdated Show resolved Hide resolved
ref(action): remove ParseShowOutputFormat
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>

@helm-bot helm-bot added size/XXL and removed size/XXL labels Mar 13, 2019

Helm 3 automation moved this from Awaiting Review to LGTM Mar 13, 2019

@bacongobbler bacongobbler merged commit e509416 into helm:dev-v3 Mar 13, 2019

2 checks passed

DCO DCO
Details
ci/circleci: build Your tests passed on CircleCI!
Details

Helm 3 automation moved this from LGTM to Done Mar 13, 2019

@bacongobbler bacongobbler deleted the bacongobbler:remove-pkg-tiller branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.