Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/chartutil: fix SaveDir for nested templates directories #5423

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
3 participants
@joelanford
Copy link
Contributor

joelanford commented Mar 8, 2019

What this PR does / why we need it:
This PR fixes chartutil.SaveDir for Helm charts that contain subdirectories in the templates directory (e.g. https://github.com/helm/charts/tree/master/stable/stolon)

Special notes for your reviewer:
Similar fix for files with nested directories here: 5b77335

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility
pkg/chartutil: fix SaveDir for nested templates directories
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

@helm-bot helm-bot added the size/S label Mar 8, 2019

@bacongobbler bacongobbler added this to the 2.14.0 milestone Mar 12, 2019

@bacongobbler bacongobbler merged commit 744cd20 into helm:master Mar 12, 2019

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@joelanford joelanford deleted the joelanford:savedir-mkdir-templates branch Mar 12, 2019

@joelanford

This comment has been minimized.

Copy link
Contributor Author

joelanford commented Mar 12, 2019

@bacongobbler Any chance this can be backported into release-2.13 for a 2.13.1 release as well?

@bacongobbler

This comment has been minimized.

Copy link
Member

bacongobbler commented Mar 12, 2019

We generally reserve patch releases for backporting regressions. This could be construed as a feature that Helm previously did not support, but it seems fairly harmless to introduce to 2.13.1. I'll bring this conversation up in the dev call next week and see what the other maintainers think about cherry-picking this into the 2.13.1 release.

@bacongobbler bacongobbler modified the milestones: 2.14.0, 2.13.1 Mar 21, 2019

@bacongobbler

This comment has been minimized.

Copy link
Member

bacongobbler commented Mar 21, 2019

cherry-picked into the 2.13.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.