fix(install): fix issue where chart metadata is not being saved on helm install
#5455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elm install` Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
bacongobbler
added
awaiting review
bug
helm-bot
added
the
size/XS
adamreese
requested changes
Mar 15, 2019
| @@ -53,6 +53,9 @@ func newStatusCmd(cfg *action.Configuration, out io.Writer) *cobra.Command { | |||
| return err | |||
| } | |||
|
|
|||
| // strip chart metadata from the output | |||
There was a problem hiding this comment.
Can you add a FIXME note. We should come up with a better solution for dumping the chart with the release.
There was a problem hiding this comment.
Just noticed the issue you created 🐑
adamreese
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5365, I changed the Chart field in the Release object to be omitted from the output so that
helm statuswould not display that information whenhelm status -o jsonwas requested. However, that resulted inhelm installomitting that information when serializing the data to be stored in the release secret.By adding the field back and stripping out the chart metadata before printing, we're able to achieve the original goal of stripping out that metadata from
helm statuswithout causing any serialization issues.This is a quick n' dirty hack to get
helm installworking again as it should. @adamreese pointed me to a solution in the Go standard library where we can translate the binary data in the release object into a struct for general consumption. I'll file a new ticket to track that refactoring work.