Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sub-command support to plugin downloader #5559

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Projects
None yet
4 participants
@steven-sheehy
Copy link
Contributor

commented Apr 5, 2019

What this PR does / why we need it:
closes #5558

Special notes for your reviewer:
If the command contains no spaces it will work exactly the same as before, making it backwards compatible.

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@helm-bot helm-bot added the size/M label Apr 5, 2019

@thomastaylor312

This comment has been minimized.

Copy link
Collaborator

commented Apr 8, 2019

This is looking good. I'll do some manual validation with it soon. I would recommend adding something to the docs about this so people know

@thomastaylor312 thomastaylor312 self-requested a review Apr 8, 2019

@steven-sheehy steven-sheehy force-pushed the steven-sheehy:downloader-subcommands branch 2 times, most recently from 7537c1b to 326dd5d Apr 8, 2019

Add sub-command support to plugin downloader
Signed-off-by: Steven Sheehy <ssheehy@firescope.com>

@steven-sheehy steven-sheehy force-pushed the steven-sheehy:downloader-subcommands branch from 326dd5d to cff2746 Apr 8, 2019

@steven-sheehy

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

@thomastaylor312 Thanks, I added a couple sentences in plugins.md about the sub-command support.

@steven-sheehy

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

@thomastaylor312 Any update?

@thomastaylor312

This comment has been minimized.

Copy link
Collaborator

commented Jul 2, 2019

@steven-sheehy I'm sorry I missed this. This was a chunk of notifications that slipped through during a busy time for me. I'll look at this this afternoon or tomorrow morning

@thomastaylor312
Copy link
Collaborator

left a comment

Thanks for the work on this!

@thomastaylor312 thomastaylor312 added this to the 2.15.0 milestone Jul 2, 2019

@bacongobbler

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Feel like porting this over to the dev-v3 branch?

@steven-sheehy

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

@bacongobbler I've never used helm v3 before, but I can take a shot at porting it later this week.

@thomastaylor312

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

Thanks for all the work @steven-sheehy!

@thomastaylor312 thomastaylor312 merged commit 4cbbd10 into helm:master Jul 8, 2019

2 checks passed

DCO DCO
Details
ci/circleci: build Your tests passed on CircleCI!
Details

@steven-sheehy steven-sheehy deleted the steven-sheehy:downloader-subcommands branch Jul 13, 2019

@steven-sheehy steven-sheehy referenced this pull request Jul 13, 2019

Merged

Helm 3: Add sub-command support to plugin downloader #6021

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.