Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding lint check for apiVersion which is a required field #5729

Merged
merged 1 commit into from May 14, 2019

Conversation

Projects
None yet
3 participants
@mattfarina
Copy link
Collaborator

commented May 14, 2019

Fixes #5727

Signed-off-by: Matt Farina matt@mattfarina.com

What this PR does / why we need it:

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility
Adding lint check for apiVersion which is a required field
Fixes #5727

Signed-off-by: Matt Farina <matt@mattfarina.com>

@mattfarina mattfarina force-pushed the mattfarina:fix-lint-apiversion branch from a1b7e8a to d4053b3 May 14, 2019

@helm-bot helm-bot added size/M and removed size/S labels May 14, 2019

@mattfarina mattfarina referenced this pull request May 14, 2019

Merged

Fix lint apiversion v3 #5730

@mattfarina

This comment has been minimized.

Copy link
Collaborator Author

commented May 14, 2019

Helm v3 PR up at #5730

@mattfarina mattfarina merged commit b4ff4d2 into helm:master May 14, 2019

2 checks passed

DCO DCO
Details
ci/circleci: build Your tests passed on CircleCI!
Details

@mattfarina mattfarina deleted the mattfarina:fix-lint-apiversion branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.