Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign updocs(install): clarify the --replace flag #7089
Conversation
The description of the `--replace` flag was unclear, as it can’t be used to replace active releases. Signed-off-by: Remco Haszing <remcohaszing@gmail.com>
@remcohaszing Thanks for pushing this clarification. I have a suggestion on the text. |
This comment has been minimized.
This comment has been minimized.
towolf
commented
Nov 27, 2019
For real, we were not using So, why does |
@remcohaszing Do you mind signing the dco: https://helm.sh/blog/helm-dco/#what-if-i-forget-to-sign-off-on-a-commit |
Signed-off-by: Remco Haszing <remcohaszing@gmail.com>
88e44fa
to
5625b14
This comment has been minimized.
This comment has been minimized.
Oops, amended |
LGTM, thanks @remcohaszing |
This comment has been minimized.
This comment has been minimized.
Going to hold off on merging as waiting on response to question asked in #7089 (comment) |
This comment has been minimized.
This comment has been minimized.
towolf
commented
Nov 28, 2019
Thanks, I'd really love to know why it's refusing to replace the resources. I think |
This comment has been minimized.
This comment has been minimized.
I also need the feature mentioned in #7089 (comment). This is why I ran into this in the first place. I created #7103 as a feature request to support this. |
This comment has been minimized.
This comment has been minimized.
@towolf Going to merge as this PR related to updating the help doc to the current implementation. Do you mind re-asking your question from #7089 (comment) in #7103 ? |
* docs(install): clarify the --replace flag The description of the `--replace` flag was unclear, as it can’t be used to replace active releases. Signed-off-by: Remco Haszing <remcohaszing@gmail.com> * docs(install): reword replace flag description Signed-off-by: Remco Haszing <remcohaszing@gmail.com>
* docs(install): clarify the --replace flag The description of the `--replace` flag was unclear, as it can’t be used to replace active releases. Signed-off-by: Remco Haszing <remcohaszing@gmail.com> * docs(install): reword replace flag description Signed-off-by: Remco Haszing <remcohaszing@gmail.com>
* docs(install): clarify the --replace flag The description of the `--replace` flag was unclear, as it can’t be used to replace active releases. Signed-off-by: Remco Haszing <remcohaszing@gmail.com> * docs(install): reword replace flag description Signed-off-by: Remco Haszing <remcohaszing@gmail.com> (cherry picked from commit af59e32)
remcohaszing commentedNov 27, 2019
The description of the
--replace
flag was unclear, as it can’t be used to replace active releases.I thought this was a bug, but the current behaviour works as expected according to some discussions in #6122.
Signed-off-by: Remco Haszing remcohaszing@gmail.com