Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(install): clarify the --replace flag #7089

Merged
merged 2 commits into from Nov 28, 2019

Conversation

@remcohaszing
Copy link
Contributor

remcohaszing commented Nov 27, 2019

The description of the --replace flag was unclear, as it can’t be used to replace active releases.

I thought this was a bug, but the current behaviour works as expected according to some discussions in #6122.

Signed-off-by: Remco Haszing remcohaszing@gmail.com

The description of the `--replace` flag was unclear, as it can’t be
used to replace active releases.

Signed-off-by: Remco Haszing <remcohaszing@gmail.com>
@helm-bot helm-bot added the size/XS label Nov 27, 2019
Copy link
Contributor

hickeyma left a comment

@remcohaszing Thanks for pushing this clarification. I have a suggestion on the text.

cmd/helm/install.go Outdated Show resolved Hide resolved
@towolf

This comment has been minimized.

Copy link

towolf commented Nov 27, 2019

For real, we were not using helm install before, due to tiller, and now want to "adopt" the existing k8s resources when they come wrapped in a helm 3 release.

So, why does helm install --replace not overwrite the existing resources, when they are found in the cluster? Why is that the expected behaviour? @bacongobbler

Copy link
Contributor

hickeyma left a comment

Signed-off-by: Remco Haszing <remcohaszing@gmail.com>
@remcohaszing remcohaszing force-pushed the remcohaszing:clarify-replace-flag branch from 88e44fa to 5625b14 Nov 28, 2019
@remcohaszing

This comment has been minimized.

Copy link
Contributor Author

remcohaszing commented Nov 28, 2019

Copy link
Contributor

hickeyma left a comment

LGTM, thanks @remcohaszing

@hickeyma

This comment has been minimized.

Copy link
Contributor

hickeyma commented Nov 28, 2019

Going to hold off on merging as waiting on response to question asked in #7089 (comment)

@towolf

This comment has been minimized.

Copy link

towolf commented Nov 28, 2019

Going to hold off on merging as waiting on response to question asked in #7089 (comment)

Thanks, I'd really love to know why it's refusing to replace the resources.

I think install --replace or maybe install --replace --force should say "these names are mine now, going to replace them".

@remcohaszing

This comment has been minimized.

Copy link
Contributor Author

remcohaszing commented Nov 28, 2019

I also need the feature mentioned in #7089 (comment). This is why I ran into this in the first place.

I created #7103 as a feature request to support this.

@hickeyma

This comment has been minimized.

Copy link
Contributor

hickeyma commented Nov 28, 2019

@towolf Going to merge as this PR related to updating the help doc to the current implementation. Do you mind re-asking your question from #7089 (comment) in #7103 ?

@hickeyma hickeyma merged commit af59e32 into helm:master Nov 28, 2019
2 checks passed
2 checks passed
DCO DCO
Details
ci/circleci: build Your tests passed on CircleCI!
Details
@hickeyma hickeyma added this to the 3.0.1 milestone Nov 28, 2019
jmcelwain added a commit to jmcelwain/helm that referenced this pull request Dec 5, 2019
* docs(install): clarify the --replace flag

The description of the `--replace` flag was unclear, as it can’t be
used to replace active releases.

Signed-off-by: Remco Haszing <remcohaszing@gmail.com>

* docs(install): reword replace flag description

Signed-off-by: Remco Haszing <remcohaszing@gmail.com>
jmcelwain added a commit to jmcelwain/helm that referenced this pull request Dec 5, 2019
* docs(install): clarify the --replace flag

The description of the `--replace` flag was unclear, as it can’t be
used to replace active releases.

Signed-off-by: Remco Haszing <remcohaszing@gmail.com>

* docs(install): reword replace flag description

Signed-off-by: Remco Haszing <remcohaszing@gmail.com>
mattfarina added a commit that referenced this pull request Dec 5, 2019
* docs(install): clarify the --replace flag

The description of the `--replace` flag was unclear, as it can’t be
used to replace active releases.

Signed-off-by: Remco Haszing <remcohaszing@gmail.com>

* docs(install): reword replace flag description

Signed-off-by: Remco Haszing <remcohaszing@gmail.com>
(cherry picked from commit af59e32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.