Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor typo #47

Merged
merged 1 commit into from Jul 31, 2021
Merged

fix minor typo #47

merged 1 commit into from Jul 31, 2021

Conversation

goshlanguage
Copy link
Contributor

@goshlanguage goshlanguage commented Jul 31, 2021

Hey friends, there's a smol typo in the README.

Thanks for your work on this project

Signed-off-by: Ryan Hartje <hartjepc@gmail.com>
@goshlanguage
Copy link
Contributor Author

@goshlanguage goshlanguage commented Jul 31, 2021

Is this still a valid input? I've tried to use this like so and got the following failure:

    steps:
      - name: Create k8s Kind Cluster
        uses: helm/kind-action@v1.2.0
        with:
          kubectl_version: "1.18.16"
Setup Kubernetes (1.18.16)
Unexpected input(s) 'kubectl_version', valid inputs are ['version', 'config', 'node_image', 'cluster_name', 'wait', 'log_level']

@davidkarlsen
Copy link
Member

@davidkarlsen davidkarlsen commented Jul 31, 2021

Is this still a valid input? I've tried to use this like so and got the following failure:

    steps:
      - name: Create k8s Kind Cluster
        uses: helm/kind-action@v1.2.0
        with:
          kubectl_version: "1.18.16"
Setup Kubernetes (1.18.16)
Unexpected input(s) 'kubectl_version', valid inputs are ['version', 'config', 'node_image', 'cluster_name', 'wait', 'log_level']

It hasn't been released yet, try the main version

@davidkarlsen davidkarlsen merged commit 2a52570 into helm:main Jul 31, 2021
3 checks passed
@goshlanguage goshlanguage deleted the readme_typo branch Aug 5, 2021
@chrisns chrisns mentioned this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants