New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update windows-capture and make it compile on windows #21
Conversation
| }; | ||
| use core_video_sys::{CVPixelBufferRef, CVPixelBufferLockBaseAddress, CVPixelBufferGetWidth, CVPixelBufferGetHeight, CVPixelBufferGetBaseAddressOfPlane, CVPixelBufferGetBytesPerRowOfPlane, CVPixelBufferUnlockBaseAddress}; | ||
|
|
||
| pub struct YUVFrame { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for moving this from here to lib.rs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea frame.rs is filled with macos only code but this struct is used in other places.
|
Thanks for the PR! I'll flick through this tomorrow β |
|
Looking forward to it! |
|
Btw this still doesn't work @NiiightmareXD: |
|
@thisislvca you need to provide it your own FFmpeg binaries. @ZohebMOPO can you document exact steps here to help? |
|
@clearlysid I did provide the binaries, the error is a standard Cargo.toml error when you have deps imported with different source paths. At least that's what I found online :) |
|
Ah! to temporarily get around this for Windows, you can comment out the ac-ffmpeg import for mac (or change it to be the same as windows) |
|
Merging this to |
|
Ok cool to know! |
Comment out the version thats for macos I did this because I don't think its good idea to down grade the ffmpeg library for macos when the problem is with windows. |
I think we need a better structure to make cross-platform development easier for example we need to implement traits for each os but for now I made it to compile on windows.
windows-capture updates:
Add Crop π
Better Threading π₯
Bug Fix β
Performance Boost π₯
Bug Fix π
Optimization π₯
Better Error Message π
Update Monitor Struct β
Mutable Buffer π₯
Bug Fix π
Low Latency π₯
Optimization π₯
Update thiserror β
Native Windows Encoder π₯
About FFmpeg: the latest version of the crate used for FFmpeg doesn't compile on windows I added a specific commit for windows that compiles but it shouldn't be a problem because I'm going to stabilize the native windows encoder and drop ffmpeg for windows completely its already used for
save_as_image.